Navigation Menu

Skip to content

Commit

Permalink
Fix a rare timing-sensitive crash when closing a window during a conn…
Browse files Browse the repository at this point in the history
…ection attempt (part of #2924)
  • Loading branch information
dmoagx committed Nov 17, 2017
1 parent 6734907 commit b9a2d6c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion Source/SPDatabaseDocument.m
Expand Up @@ -6534,8 +6534,11 @@ - (void)dealloc

if (processListController) [processListController close];

// #2924: The connection controller doesn't retain its delegate (us), but it may outlive us (e.g. when running a bg thread)
[connectionController setDelegate:nil];
SPClear(connectionController);

if (selectedTableName) SPClear(selectedTableName);
if (connectionController) SPClear(connectionController);
if (processListController) SPClear(processListController);
if (serverVariablesController) SPClear(serverVariablesController);
if (mySQLConnection) SPClear(mySQLConnection);
Expand Down

0 comments on commit b9a2d6c

Please sign in to comment.