Skip to content

Commit c2fe67b

Browse files
committed
#63: Rename class SPTableContentFilterController to SPRuleFilterController to reduce confusion
1 parent e49d33e commit c2fe67b

6 files changed

Lines changed: 46 additions & 46 deletions

File tree

Interfaces/English.lproj/DBView.xib

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4596,7 +4596,7 @@ Gw
45964596
<outlet property="contentViewPane" destination="27" id="6661"/>
45974597
<outlet property="countText" destination="261" id="262"/>
45984598
<outlet property="duplicateButton" destination="5178" id="7837"/>
4599-
<outlet property="filterControllerInstance" destination="ki9-Po-bdr" id="5od-0U-9xj"/>
4599+
<outlet property="ruleFilterController" destination="ki9-Po-bdr" id="5od-0U-9xj"/>
46004600
<outlet property="filterRuleEditorContainer" destination="9oo-u0-ndW" id="OZb-jI-CMy"/>
46014601
<outlet property="filterTableController" destination="UBS-cN-3Af" id="FV7-by-Gy1"/>
46024602
<outlet property="multipleLineEditingButton" destination="5201" id="5203"/>
@@ -4616,7 +4616,7 @@ Gw
46164616
<outlet property="toggleRuleFilterButton" destination="LYg-Ux-Lph" id="9eY-dL-AhC"/>
46174617
</connections>
46184618
</customObject>
4619-
<customObject id="ki9-Po-bdr" userLabel="SPTableContentFilter" customClass="SPTableContentFilterController">
4619+
<customObject id="ki9-Po-bdr" userLabel="SPRuleFilter" customClass="SPRuleFilterController">
46204620
<connections>
46214621
<outlet property="filterButton" destination="4676" id="9tZ-dW-BR3"/>
46224622
<outlet property="filterRuleEditor" destination="FF9-z2-9od" id="RW4-XM-XQS"/>
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//
2-
// SPTableContentFilterController.h
2+
// SPRuleFilterController.h
33
// sequel-pro
44
//
55
// Created by Max Lohrmann on 04.05.18.
@@ -33,9 +33,9 @@
3333
@class SPTablesList;
3434
@class SPContentFilterManager;
3535

36-
NSString * const SPTableContentFilterHeightChangedNotification;
36+
NSString * const SPRuleFilterHeightChangedNotification;
3737

38-
@interface SPTableContentFilterController : NSObject {
38+
@interface SPRuleFilterController : NSObject {
3939
IBOutlet NSRuleEditor *filterRuleEditor;
4040
IBOutlet SPTableData *tableDataInstance;
4141
IBOutlet SPDatabaseDocument *tableDocumentInstance;
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//
2-
// SPTableContentFilterController.m
2+
// SPRuleFilterController.m
33
// sequel-pro
44
//
55
// Created by Max Lohrmann on 04.05.18.
@@ -28,7 +28,7 @@
2828
//
2929
// More info at <https://github.com/sequelpro/sequelpro>
3030

31-
#import "SPTableContentFilterController.h"
31+
#import "SPRuleFilterController.h"
3232
#import "SPQueryController.h"
3333
#import "SPDatabaseDocument.h"
3434
#import "RegexKitLite.h"
@@ -44,7 +44,7 @@ typedef NS_ENUM(NSInteger, RuleNodeType) {
4444
RuleNodeTypeConnector,
4545
};
4646

47-
NSString * const SPTableContentFilterHeightChangedNotification = @"SPTableContentFilterHeightChanged";
47+
NSString * const SPRuleFilterHeightChangedNotification = @"SPRuleFilterHeightChanged";
4848

4949
/**
5050
* The type of filter rule that the current item represents.
@@ -164,7 +164,7 @@ @interface ConnectorNode : RuleNode {
164164

165165
#pragma mark -
166166

167-
@interface SPTableContentFilterController () <NSRuleEditorDelegate>
167+
@interface SPRuleFilterController () <NSRuleEditorDelegate>
168168

169169
@property (readwrite, assign, nonatomic) CGFloat preferredHeight;
170170

@@ -190,7 +190,7 @@ - (IBAction)filterTable:(id)sender;
190190

191191
@end
192192

193-
@implementation SPTableContentFilterController
193+
@implementation SPRuleFilterController
194194

195195
@synthesize model = model;
196196
@synthesize preferredHeight = preferredHeight;
@@ -505,7 +505,7 @@ - (void)_resize
505505
}
506506
if(wantsHeight != preferredHeight) {
507507
[self setPreferredHeight:wantsHeight];
508-
[[NSNotificationCenter defaultCenter] postNotificationName:SPTableContentFilterHeightChangedNotification object:self];
508+
[[NSNotificationCenter defaultCenter] postNotificationName:SPRuleFilterHeightChangedNotification object:self];
509509
}
510510
}
511511

Source/SPTableContent.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
@class SPDatabaseDocument;
4444
@class SPTablesList;
4545
@class SPTableStructure;
46-
@class SPTableContentFilterController;
46+
@class SPRuleFilterController;
4747
@class SPFilterTableController;
4848

4949
typedef NS_ENUM(NSInteger, SPTableContentFilterSource) {
@@ -96,7 +96,7 @@ typedef NS_ENUM(NSInteger, SPTableContentFilterSource) {
9696
#ifndef SP_CODA
9797
IBOutlet NSStepper *paginationPageStepper;
9898

99-
IBOutlet SPTableContentFilterController *filterControllerInstance;
99+
IBOutlet SPRuleFilterController *ruleFilterController;
100100
IBOutlet SPFilterTableController *filterTableController;
101101
BOOL scrollViewHasRubberbandScrolling;
102102
#endif

Source/SPTableContent.m

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
#import "SPThreadAdditions.h"
5757
#import "SPTableFilterParser.h"
5858
#import "SPFunctions.h"
59-
#import "SPTableContentFilterController.h"
59+
#import "SPRuleFilterController.h"
6060
#import "SPFilterTableController.h"
6161

6262
#import <pthread.h>
@@ -235,20 +235,20 @@ - (void)awakeFromNib
235235
// Add observer to change view sizes with filter rule editor
236236
[[NSNotificationCenter defaultCenter] addObserver:self
237237
selector:@selector(filterRuleEditorPreferredSizeChanged:)
238-
name:SPTableContentFilterHeightChangedNotification
239-
object:filterControllerInstance];
238+
name:SPRuleFilterHeightChangedNotification
239+
object:ruleFilterController];
240240
[contentAreaContainer setPostsFrameChangedNotifications:YES];
241241
[[NSNotificationCenter defaultCenter] addObserver:self
242242
selector:@selector(contentViewSizeChanged:)
243243
name:NSViewFrameDidChangeNotification
244244
object:contentAreaContainer];
245-
[filterControllerInstance setTarget:self];
246-
[filterControllerInstance setAction:@selector(filterTable:)];
245+
[ruleFilterController setTarget:self];
246+
[ruleFilterController setAction:@selector(filterTable:)];
247247

248248
[filterTableController setTarget:self];
249249
[filterTableController setAction:@selector(filterTable:)];
250250
//TODO This is only needed for 10.6 compatibility
251-
scrollViewHasRubberbandScrolling = [[[filterControllerInstance view] enclosingScrollView] respondsToSelector:@selector(setVerticalScrollElasticity:)];
251+
scrollViewHasRubberbandScrolling = [[[ruleFilterController view] enclosingScrollView] respondsToSelector:@selector(setVerticalScrollElasticity:)];
252252

253253
// Add observers for document task activity
254254
[[NSNotificationCenter defaultCenter] addObserver:self
@@ -362,7 +362,7 @@ - (void)_setViewBlankState
362362
[self setRuleEditorVisible:NO animate:NO];
363363
[toggleRuleFilterButton setEnabled:NO];
364364
[toggleRuleFilterButton setState:NSOffState];
365-
[filterControllerInstance setColumns:nil];
365+
[ruleFilterController setColumns:nil];
366366

367367
// Disable pagination
368368
[paginationPreviousButton setEnabled:NO];
@@ -634,9 +634,9 @@ - (void) setTableDetails:(NSDictionary *)tableDetails
634634

635635
[filterTableController setColumns:dataColumns];
636636
// Enable and initialize filter fields (with tags for position of menu item and field position)
637-
[filterControllerInstance setColumns:dataColumns];
637+
[ruleFilterController setColumns:dataColumns];
638638
// Restore preserved filter settings if appropriate and valid
639-
[filterControllerInstance restoreSerializedFilters:filtersToRestore];
639+
[ruleFilterController restoreSerializedFilters:filtersToRestore];
640640
// hide/show the rule filter editor, based on its previous state (so that it says visible when switching tables, if someone has enabled it and vice versa)
641641
if(showFilterRuleEditor) {
642642
[self setRuleEditorVisible:YES animate:NO];
@@ -646,7 +646,7 @@ - (void) setTableDetails:(NSDictionary *)tableDetails
646646
[self setRuleEditorVisible:NO animate:NO];
647647
[toggleRuleFilterButton setState:NSOffState];
648648
}
649-
[filterControllerInstance setEnabled:enableInteraction];
649+
[ruleFilterController setEnabled:enableInteraction];
650650
[toggleRuleFilterButton setEnabled:enableInteraction];
651651
// restore the filter to the previously choosen one for the table
652652
activeFilter = activeFilterToRestore;
@@ -1014,7 +1014,7 @@ - (NSString *)tableFilterString
10141014
BOOL caseSensitive = (([[NSApp currentEvent] modifierFlags] & NSShiftKeyMask) > 0);
10151015

10161016
NSError *err = nil;
1017-
NSString *filter = [filterControllerInstance sqlWhereExpressionWithBinary:caseSensitive error:&err];
1017+
NSString *filter = [ruleFilterController sqlWhereExpressionWithBinary:caseSensitive error:&err];
10181018
if(err) {
10191019
SPOnewayAlertSheet(
10201020
NSLocalizedString(@"Invalid Filter", @"table content : apply filter : invalid filter message title"),
@@ -1256,7 +1256,7 @@ - (IBAction)filterTable:(id)sender
12561256
}
12571257
// If a button other than the pagination buttons was used, set the active filter type to
12581258
// the standard filter field.
1259-
else if (sender == filterControllerInstance) {
1259+
else if (sender == ruleFilterController) {
12601260
activeFilter = SPTableContentFilterSourceRuleFilter;
12611261
resetPaging = YES;
12621262
}
@@ -1349,12 +1349,12 @@ - (void)setRuleEditorVisible:(BOOL)show animate:(BOOL)animate
13491349
{
13501350
// we can't change the state of the button here, because the mouse click already changed it
13511351
if(show) {
1352-
if([filterControllerInstance isEmpty]) {
1353-
[filterControllerInstance addFilterExpression];
1352+
if([ruleFilterController isEmpty]) {
1353+
[ruleFilterController addFilterExpression];
13541354
// the sizing will be updated automatically by adding a row
13551355
}
13561356
else {
1357-
[self updateFilterRuleEditorSize:[filterControllerInstance preferredHeight] animate:animate];
1357+
[self updateFilterRuleEditorSize:[ruleFilterController preferredHeight] animate:animate];
13581358
}
13591359
}
13601360
else {
@@ -2388,14 +2388,14 @@ - (void)clickLinkArrowTask:(SPTextAndLinkCell *)theArrowCell
23882388
else if(navigateAsHex) filterComparison = @"= (Hex String)";
23892389

23902390
// Store the filter details to use when loading the target table
2391-
NSDictionary *filterSettings = [SPTableContentFilterController makeSerializedFilterForColumn:[refDictionary objectForKey:@"column"]
2391+
NSDictionary *filterSettings = [SPRuleFilterController makeSerializedFilterForColumn:[refDictionary objectForKey:@"column"]
23922392
operator:filterComparison
23932393
values:@[targetFilterValue]];
23942394

23952395
// If the link is within the current table, apply filter settings manually
23962396
if ([[refDictionary objectForKey:@"table"] isEqualToString:selectedTable]) {
23972397
SPMainQSync(^{
2398-
[filterControllerInstance restoreSerializedFilters:filterSettings];
2398+
[ruleFilterController restoreSerializedFilters:filterSettings];
23992399
[self setRuleEditorVisible:YES animate:YES];
24002400
activeFilter = SPTableContentFilterSourceRuleFilter;
24012401
});
@@ -3337,7 +3337,7 @@ - (CGFloat) tablesListWidth
33373337
*/
33383338
- (NSDictionary *) filterSettings
33393339
{
3340-
return [filterControllerInstance serializedFilter];
3340+
return [ruleFilterController serializedFilter];
33413341
}
33423342

33433343
/**
@@ -3445,7 +3445,7 @@ - (void)updateFilterRuleEditorSize:(CGFloat)requestedHeight animate:(BOOL)animat
34453445
NSRect contentAreaRect = [contentAreaContainer frame];
34463446
CGFloat availableHeight = contentAreaRect.size.height;
34473447

3448-
NSRect ruleEditorRect = [[[filterControllerInstance view] enclosingScrollView] frame];
3448+
NSRect ruleEditorRect = [[[ruleFilterController view] enclosingScrollView] frame];
34493449

34503450
//adjust for the UI elements below the rule editor, but only if the view height should not be 0 (ie. hidden)
34513451
CGFloat containerRequestedHeight = requestedHeight ? requestedHeight + ruleEditorRect.origin.y : 0;
@@ -3472,18 +3472,18 @@ - (void)updateFilterRuleEditorSize:(CGFloat)requestedHeight animate:(BOOL)animat
34723472
[NSAnimationContext beginGrouping];
34733473
[[tableContentContainer animator] setFrame:bottomContainerRect];
34743474
[[filterRuleEditorContainer animator] setFrame:topContainerRect];
3475-
[[[[filterControllerInstance view] enclosingScrollView] animator] setFrame:ruleEditorRect];
3475+
[[[[ruleFilterController view] enclosingScrollView] animator] setFrame:ruleEditorRect];
34763476
[NSAnimationContext endGrouping];
34773477
}
34783478
else {
34793479
[tableContentContainer setFrameSize:bottomContainerRect.size];
34803480
[filterRuleEditorContainer setFrame:topContainerRect];
3481-
[[[filterControllerInstance view] enclosingScrollView] setFrame:ruleEditorRect];
3481+
[[[ruleFilterController view] enclosingScrollView] setFrame:ruleEditorRect];
34823482
}
34833483

34843484
//disable rubberband scrolling as long as there is nothing to scroll
34853485
if(scrollViewHasRubberbandScrolling) {
3486-
NSScrollView *filterControllerScroller = [[filterControllerInstance view] enclosingScrollView];
3486+
NSScrollView *filterControllerScroller = [[ruleFilterController view] enclosingScrollView];
34873487
if (ruleEditorRect.size.height >= requestedHeight) {
34883488
[filterControllerScroller setVerticalScrollElasticity:NSScrollElasticityNone];
34893489
} else {
@@ -3495,14 +3495,14 @@ - (void)updateFilterRuleEditorSize:(CGFloat)requestedHeight animate:(BOOL)animat
34953495
- (void)filterRuleEditorPreferredSizeChanged:(NSNotification *)notification
34963496
{
34973497
if(showFilterRuleEditor) {
3498-
[self updateFilterRuleEditorSize:[filterControllerInstance preferredHeight] animate:YES];
3498+
[self updateFilterRuleEditorSize:[ruleFilterController preferredHeight] animate:YES];
34993499
}
35003500
}
35013501

35023502
- (void)contentViewSizeChanged:(NSNotification *)notification
35033503
{
35043504
if(showFilterRuleEditor) {
3505-
[self updateFilterRuleEditorSize:[filterControllerInstance preferredHeight] animate:NO];
3505+
[self updateFilterRuleEditorSize:[ruleFilterController preferredHeight] animate:NO];
35063506
}
35073507
}
35083508

@@ -3627,7 +3627,7 @@ - (void) startDocumentTaskForTab:(NSNotification *)aNotification
36273627
[removeButton setEnabled:NO];
36283628
[duplicateButton setEnabled:NO];
36293629
[reloadButton setEnabled:NO];
3630-
[filterControllerInstance setEnabled:NO];
3630+
[ruleFilterController setEnabled:NO];
36313631
[toggleRuleFilterButton setEnabled:NO];
36323632
tableRowsSelectable = NO;
36333633
[paginationPreviousButton setEnabled:NO];
@@ -3663,7 +3663,7 @@ - (void) endDocumentTaskForTab:(NSNotification *)aNotification
36633663
}
36643664
}
36653665

3666-
[filterControllerInstance setEnabled:(!![selectedTable length])];
3666+
[ruleFilterController setEnabled:(!![selectedTable length])];
36673667
[toggleRuleFilterButton setEnabled:(!![selectedTable length])];
36683668
tableRowsSelectable = YES;
36693669
}
@@ -3931,7 +3931,7 @@ - (void)makeContentFilterHaveFocus
39313931
{
39323932
[self setRuleEditorVisible:YES animate:YES];
39333933
[toggleRuleFilterButton setState:NSOnState];
3934-
[filterControllerInstance focusFirstInputField];
3934+
[ruleFilterController focusFirstInputField];
39353935
}
39363936

39373937
#endif

sequel-pro.xcodeproj/project.pbxproj

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@
185185
503CDBB21ACDC204004F8A2F /* Quartz.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 503CDBB11ACDC204004F8A2F /* Quartz.framework */; };
186186
505F568F1BCEE485007467DD /* SPFunctions.m in Sources */ = {isa = PBXBuildFile; fileRef = 507FF1111BBCC57600104523 /* SPFunctions.m */; };
187187
505F56901BCEE491007467DD /* SPOSInfo.m in Sources */ = {isa = PBXBuildFile; fileRef = 50EAB5B71A8FBB08008F627A /* SPOSInfo.m */; };
188-
506CE9311A311C6C0039F736 /* SPTableContentFilterController.m in Sources */ = {isa = PBXBuildFile; fileRef = 506CE9301A311C6C0039F736 /* SPTableContentFilterController.m */; };
188+
506CE9311A311C6C0039F736 /* SPRuleFilterController.m in Sources */ = {isa = PBXBuildFile; fileRef = 506CE9301A311C6C0039F736 /* SPRuleFilterController.m */; };
189189
507FF1121BBCC57600104523 /* SPFunctions.m in Sources */ = {isa = PBXBuildFile; fileRef = 507FF1111BBCC57600104523 /* SPFunctions.m */; };
190190
507FF1621BBF0D5000104523 /* SPTableCopyTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 112730551180788A000737FD /* SPTableCopyTest.m */; };
191191
507FF2421BC33BBC00104523 /* SPOSInfo.m in Sources */ = {isa = PBXBuildFile; fileRef = 50EAB5B71A8FBB08008F627A /* SPOSInfo.m */; };
@@ -886,8 +886,8 @@
886886
503B02C91AE82C5E0060CAB1 /* SPTableFilterParser.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SPTableFilterParser.m; sourceTree = "<group>"; };
887887
503B02CE1AE95C2C0060CAB1 /* SPTableFilterParserTest.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SPTableFilterParserTest.m; sourceTree = "<group>"; };
888888
503CDBB11ACDC204004F8A2F /* Quartz.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Quartz.framework; path = System/Library/Frameworks/Quartz.framework; sourceTree = SDKROOT; };
889-
506CE92F1A311C6C0039F736 /* SPTableContentFilterController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SPTableContentFilterController.h; sourceTree = "<group>"; };
890-
506CE9301A311C6C0039F736 /* SPTableContentFilterController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SPTableContentFilterController.m; sourceTree = "<group>"; };
889+
506CE92F1A311C6C0039F736 /* SPRuleFilterController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SPRuleFilterController.h; sourceTree = "<group>"; };
890+
506CE9301A311C6C0039F736 /* SPRuleFilterController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SPRuleFilterController.m; sourceTree = "<group>"; };
891891
507FF1101BBCC4C400104523 /* SPFunctions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SPFunctions.h; sourceTree = "<group>"; };
892892
507FF1111BBCC57600104523 /* SPFunctions.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SPFunctions.m; sourceTree = "<group>"; };
893893
508022941BF7BA470052A9B2 /* English */ = {isa = PBXFileReference; lastKnownFileType = text.html; name = English; path = English.lproj/SPQLPluginExportSettingsTemplate.html; sourceTree = "<group>"; };
@@ -1568,8 +1568,8 @@
15681568
17A7773311C52D8E001E27B4 /* SPIndexesController.m */,
15691569
50A9F8AF19EAD4B90053E571 /* SPGotoDatabaseController.h */,
15701570
50A9F8B019EAD4B90053E571 /* SPGotoDatabaseController.m */,
1571-
506CE92F1A311C6C0039F736 /* SPTableContentFilterController.h */,
1572-
506CE9301A311C6C0039F736 /* SPTableContentFilterController.m */,
1571+
506CE92F1A311C6C0039F736 /* SPRuleFilterController.h */,
1572+
506CE9301A311C6C0039F736 /* SPRuleFilterController.m */,
15731573
1713C73D140D88D400CFD461 /* Query Controller */,
15741574
17381853151FB29C0078FFE2 /* User Manager */,
15751575
17846B9D170C95D800414499 /* Process List */,
@@ -3263,7 +3263,7 @@
32633263
1785EB6A127DD79300F468C8 /* SPEditorPreferencePane.m in Sources */,
32643264
17FDB04C1280778B00DBBBC2 /* SPFontPreviewTextField.m in Sources */,
32653265
17D3C22212859E070047709F /* SPFavoriteNode.m in Sources */,
3266-
506CE9311A311C6C0039F736 /* SPTableContentFilterController.m in Sources */,
3266+
506CE9311A311C6C0039F736 /* SPRuleFilterController.m in Sources */,
32673267
17D3C66E128AD4710047709F /* SPFavoritesController.m in Sources */,
32683268
17D3C671128AD8160047709F /* SPSingleton.m in Sources */,
32693269
17D3C6D3128B1C900047709F /* SPFavoritesOutlineView.m in Sources */,

0 commit comments

Comments
 (0)