Skip to content
Permalink
Browse files

Fix export label for delimiter #3389

  • Loading branch information...
Kaspik committed Feb 20, 2019
1 parent 3e40b24 commit c9e1d36f73e845aeca597467d97afb536f184d87
Showing with 40 additions and 52 deletions.
  1. +40 −52 Interfaces/English.lproj/ExportDialog.xib
Oops, something went wrong.

4 comments on commit c9e1d36

@dmoagx

This comment has been minimized.

Copy link
Member

dmoagx replied Feb 20, 2019

I'll have to revert this.
When changing IB files please make sure to only commit the changes that were actually intended.

@Kaspik

This comment has been minimized.

Copy link
Collaborator Author

Kaspik replied Feb 20, 2019

Okay, does it mean our xibs are still older version for older xcodes?

@dmoagx

This comment has been minimized.

Copy link
Member

dmoagx replied Feb 20, 2019

Yes, you can see that right in the header:

<development version="5100" identifier="xcode"/>

5100 means 5.1.

See this table for which OS version that relates to: https://github.com/sequelpro/sequelpro/wiki/Xcode-Compatibility

I personally need them to be compatible to 6.2 and for the next release they must be compatible to 7.3.1 because that is the last version to officially compile for 10.6.

The main issue here however is, that Xcode will change lots of stuff in XIB files every time you just open and save them, even if you didn't make any change (and the next time it will change it back to the previous values, most of the time). That makes it difficult to track the intended changes to the files so our policy is to only commit the actual changes (many git clients allow you to select the changes line by line).

@Kaspik

This comment has been minimized.

Copy link
Collaborator Author

Kaspik replied Feb 20, 2019

... yes, I know, one of many reasons why we don’t have yibs/storyboards and do UI in code on our projects. :) thanks for links, I’ll keep an eye on that until next release.

Please sign in to comment.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.