Change a potentially risky call (hopefully a fix for #2436)

dmoagx · dmoagx · commit dfc79b8c7ee2 · 2016-03-06T01:23:02.000+01:00
diff --git a/Source/SPDatabaseData.m b/Source/SPDatabaseData.m
@@ -221,7 +221,7 @@ - (NSString *)getDefaultCollationForEncoding:(NSString *)encoding
 			}
 		}
 	}
-	return defaultCollationForCharacterSet;
+	return [[defaultCollationForCharacterSet copy] autorelease]; // -copy accepts nil, -stringWithString: does not
 }
 
 /** Get the name of the mysql charset a given collation belongs to.

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ - (NSString )getDefaultCollationForEncoding:(NSString )encoding`
`221`	`221`	`}`
`222`	`222`	`}`
`223`	`223`	`}`
`224`		`- return defaultCollationForCharacterSet;`
	`224`	`+ return [[defaultCollationForCharacterSet copy] autorelease]; // -copy accepts nil, -stringWithString: does not`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`/** Get the name of the mysql charset a given collation belongs to.`