Can't open more than one .spf file #2294

Closed
zledwon opened this Issue Oct 19, 2015 · 11 comments

Projects

None yet

2 participants

@zledwon
zledwon commented Oct 19, 2015

If I have a connection open (manually or from saved .spf file) Sequelpro won't open next .spf file, just starts empty new connection.
MacBook Pro late 2011, El Capitan

@dmoagx
Collaborator
dmoagx commented Oct 21, 2015

What do you mean by manually?

Opening an SPF file works fine for me. I can even open the same file multiple times to create multiple connection windows (from Finder and from File > Open...).

Try saving the SPF file again with 1.1 and see if that changes anything.
If yes, open them both in TextMate/SublimeText/etc. and look for differences.

Also, there are "connection" files and "session" files – which do you mean?

@zledwon
zledwon commented Oct 23, 2015

By "manually" I mean - entering connection data to the connection form (instead of opening SPF file).

All my SPF files are saved with v. 1.1, and these are 'connection' files.

Take a look at this video https://youtu.be/QZOR8zoMdkQ to see how it happens.
I open one SPF file - it works fine; then I open another one but it just opens new empty connection.
Then I open those two files in reverse order, and the result is the same: first file always works fine and the next is just opening empty connection window.

@dmoagx
Collaborator
dmoagx commented Oct 26, 2015

Instead of Path Finder, can you try regular Finder or from Terminal (with the open command)?

@zledwon
zledwon commented Oct 26, 2015

I tried all 3 (Finder, Terminal and PF) - works exactly the same, but since I tested it a bit more I have new clues:

  • first spf always opens normally
  • second NEVER opens (just opens new empty connection)
  • third, fourth and next ones opens (but in the background - empty connection window stays on top)

If I close the empty connection window and try to open another spf - it will not work, just opens new empty connection.

@dmoagx
Collaborator
dmoagx commented Oct 26, 2015
  • Do you have any system enhancements (e.g. SIMBL or tools using Accessibility Services)?
  • Check Console.app for messages when you open a spf file
  • Please create a new user account on your Mac and try it there.
@zledwon
zledwon commented Oct 26, 2015
  • I do not use any system enhancements
  • checked the Console but no messages showed up during opening spf files
  • created and checked on new user account - same results, same behaviour
@dmoagx
Collaborator
dmoagx commented Nov 4, 2015

OK, this issue seems to be limited to 10.11

@dmoagx dmoagx added Bug and removed WaitingOnUser labels Nov 4, 2015
@dmoagx
Collaborator
dmoagx commented Nov 4, 2015

So it looks like Apple made a change to the window handling.

When opening a new window, Sequel Pro relies on the new window being in front, which has always been the case in the past.
However in 10.11 the new window is created in the back and only later moved to the front.

That is too late for Sequel Pro, which will just take the window that was already open instead and try to restore a connection there (which doesn't work, of course).

Looks like we are not the only ones bitten by that:
https://code.google.com/p/chromium/issues/detail?id=518983#c5

@dmoagx dmoagx added a commit that referenced this issue Nov 5, 2015
@dmoagx dmoagx * Change window creation to use a create-and-get model instead of cre…
…ate-then-get as that did cause problems on 10.11 in some cases (#2294)

* Split a huuuuge method into many smaller methods
* Updated some code to use methods that are already there
ea1d728
@dmoagx
Collaborator
dmoagx commented Nov 5, 2015

The last commit should hopefully fix that.
You can try a development build from http://nightly.sequelpro.com/

I'm not entirely sure how much of that change to backport for 1.1.1

@zledwon
zledwon commented Nov 5, 2015

Yes. This was it. Problem is gone in 'nightly' :)

@dmoagx dmoagx added a commit that referenced this issue Nov 5, 2015
@dmoagx dmoagx * Change window creation to use a create-and-get model instead of cre…
…ate-then-get as that did cause problems on 10.11 in some cases (#2294)

backport of ea1d728
5cd1239
@dmoagx dmoagx added this to the 1.1.1 milestone Nov 5, 2015
@dmoagx
Collaborator
dmoagx commented Feb 20, 2016
@dmoagx dmoagx closed this Feb 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment