New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input field bundles no longer work in popup editor #2299
Comments
Ok, 50% of that issue was me removing the "mainWindow" state from the field editor and the other 50% goes to whoever assumed the |
…ibly other cases) (#2299) Replacing some [NSApp mainWindow] with their actually intended calls [NSApp keyWindow] and [view window]
…ibly other cases) (#2299) Replacing some [NSApp mainWindow] with their actually intended calls [NSApp keyWindow] and [view window]
Hopefully that won't cause any side effects again… |
@dmoagx this is a pretty serious bug. The ability to deserialize large PHP arrays/objects is now impossible inside the stable released versions of the app (which is what I use the app for 90% of the time). I just tried the nightly build and I can confirm the above commits have sort of fixed this issue. It will work if you use the main or context menu to manually select the bundle, however the key bindings still do not work after the pop-up sheet shows up. This is the main menu for the bundle. Notice there is no key binding, which may be part of the issue? This is the context menu inside the pop-up sheet (right click), which shows the key binding, but doesn't work: Also, is it possible that this issue (once fully fixed) be released before the 1.1.1 milestone or in place of it? |
I'm also receiving the following crash on some larger PHP arrays. I've redacted the full contents of the array, but it appears that it's attempting to assign a system variable (to be used on the shell script)? Possible it's not fully escaping the value properly?
|
How many characters did it have? |
|
OK, the length shouldn't be a problem, but your string most likely contains special characters. |
Yes, I see a lot of |
Let's continue the discussion on the exception in #2342. The issue with the keyboard shortcut most likely has something to with the fact that "Shift+cmd+D" is already assigned to "Go to Database…". |
Huh, that's interesting. I just looked at the code and it looks like OS X interprets:
(the different combinations are only accessible via code) while our version of ShortcutRecorder assumes |
Hm, odd indeed. I suppose this issue could get closed then (as the above commits actually fixed the problem). I'm still a bit confused as to which shortcut "Go to Database..." should be using though. If it's any consolation, the bundle I use has always been assigned to |
The database selection always has been cmd+shift+D, but there was no main menu item for this before, which is probably why you are only seeing it now. You can try this workaround: That should work fine. The bug only affects assigning keyboard shortcuts. |
Issue fixed in 1.1.1 |
From Twitter:
Input field bundles used to work in 1.0.2 in the popup field editor, too, but don't anymore in 1.1.
The text was updated successfully, but these errors were encountered: