Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSL for Feedback Reporter #2524

Open
dmoagx opened this issue Jun 26, 2016 · 2 comments
Open

Add SSL for Feedback Reporter #2524

dmoagx opened this issue Jun 26, 2016 · 2 comments
Labels
Bug Fixed-AwaitingRelease
Projects
Sequel Pro 1.2

Comments

@dmoagx
Copy link
Member

dmoagx commented Jun 26, 2016

It looks like recent nightly builds can no longer submit crash reports because Apple requires HTTPS communication now.
@dmoagx dmoagx added the Bug label Jun 26, 2016
@abhibeckert
Copy link
Member

Apple doesn't require it, I updated the info.plist to require SSL as part of fixing the sparkle vulnerability.

@dmoagx dmoagx added this to the 1.2 milestone Aug 3, 2016
@abhibeckert abhibeckert added this to Scheduled in Sequel Pro 1.2 Feb 2, 2017
@abhibeckert abhibeckert moved this from Required to In Progress in Sequel Pro 1.2 Feb 2, 2017
abhibeckert added a commit to abhibeckert/sequelpro that referenced this issue Mar 3, 2017
@abhibeckert
sequelpro#2524 New URL for reedback reporter, using SSL
4dfd429
@abhibeckert
Copy link
Member

This should be fixed but needs testing.

I tried deliberately causing a crash but didn't get the feedback reporter popup. Any idea why?

@abhibeckert abhibeckert moved this from In Progress to Done in Sequel Pro 1.2 Mar 7, 2017
@abhibeckert abhibeckert removed this from the 1.2 milestone Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Fixed-AwaitingRelease
Projects
Sequel Pro 1.2
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhibeckert @dmoagx