New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Xcode 10 doesn't build #3179

Open
enx1998 opened this Issue Sep 26, 2018 · 12 comments

Comments

7 participants
@enx1998

enx1998 commented Sep 26, 2018

Hi, with Xcode 10.0 (10A255) repo update at the latest commit (c0ac6ed) doesn't compile because of i386 architecture.
Here are the errors:

Build system information
error: The i386 architecture is deprecated. You should update your ARCHS build setting to remove the i386 architecture. (in target 'SequelProTunnelAssistant')
Build system information
error: The i386 architecture is deprecated. You should update your ARCHS build setting to remove the i386 architecture. (in target 'Sequel Pro QLGenerator')
Build system information
error: The i386 architecture is deprecated. You should update your ARCHS build setting to remove the i386 architecture. (in target 'xibLocalizationPostprocessor')
Build system information
error: The i386 architecture is deprecated. You should update your ARCHS build setting to remove the i386 architecture. (in target 'PSMTabBar')

image
Is there anything I can do to do a succesful compilation?

Thanks ENx

@unCleanCode

This comment has been minimized.

Show comment
Hide comment
@unCleanCode

unCleanCode Sep 28, 2018

I tried removing i386 from ARCHS list. But then I'm getting an error of SPMySQL.h file not found, so didn't succeed in compiling it either
Really want to get new version with dark theme and bugfixes asap. That's the last light app on my computer and it blinds me at night :(

unCleanCode commented Sep 28, 2018

I tried removing i386 from ARCHS list. But then I'm getting an error of SPMySQL.h file not found, so didn't succeed in compiling it either
Really want to get new version with dark theme and bugfixes asap. That's the last light app on my computer and it blinds me at night :(

@khanhicetea

This comment has been minimized.

Show comment
Hide comment
@khanhicetea

khanhicetea Oct 1, 2018

I built successfully the latest commit in XCode 10 (macOS Mojave). You can follow these steps on my blog article : https://khanhicetea.com/post/build-sequel-pro-from-source-in-xcode-10/

image

Hope it help

khanhicetea commented Oct 1, 2018

I built successfully the latest commit in XCode 10 (macOS Mojave). You can follow these steps on my blog article : https://khanhicetea.com/post/build-sequel-pro-from-source-in-xcode-10/

image

Hope it help

@jeffcross

This comment has been minimized.

Show comment
Hide comment
@jeffcross

jeffcross Oct 1, 2018

Thank you, @khanhicetea! I followed your directions and with only one minor change to the copy command at the end, I am on the latest and greatest version... with Dark Mode!

When I ran the copy command you supplied, I received an error:

$ cp build/Release/Sequel\ Pro.app /Applications/Sequel\ Pro.app
cp: build/Release/Sequel Pro.app is a directory (not copied).

Ah, makes sense... I simply added a -R to the copy command and everything is working as expected!

$ cp -R build/Release/Sequel\ Pro.app /Applications/Sequel\ Pro.app

screen shot 2018-10-01 at 8 18 04 am

jeffcross commented Oct 1, 2018

Thank you, @khanhicetea! I followed your directions and with only one minor change to the copy command at the end, I am on the latest and greatest version... with Dark Mode!

When I ran the copy command you supplied, I received an error:

$ cp build/Release/Sequel\ Pro.app /Applications/Sequel\ Pro.app
cp: build/Release/Sequel Pro.app is a directory (not copied).

Ah, makes sense... I simply added a -R to the copy command and everything is working as expected!

$ cp -R build/Release/Sequel\ Pro.app /Applications/Sequel\ Pro.app

screen shot 2018-10-01 at 8 18 04 am

@khanhicetea

This comment has been minimized.

Show comment
Hide comment
@khanhicetea

khanhicetea Oct 1, 2018

Ah, makes sense... I simply added a -R `to the copy command and everything is working as expected!

$ cp -R build/Release/Sequel\ Pro.app /Applications/Sequel\ Pro.app

Yeah thanks, I forgot -R , updated my post !

khanhicetea commented Oct 1, 2018

Ah, makes sense... I simply added a -R `to the copy command and everything is working as expected!

$ cp -R build/Release/Sequel\ Pro.app /Applications/Sequel\ Pro.app

Yeah thanks, I forgot -R , updated my post !

@cron13

This comment has been minimized.

Show comment
Hide comment
@cron13

cron13 Oct 2, 2018

Good day, can you share builded app please?
i don't wanna install xcode for one app

cron13 commented Oct 2, 2018

Good day, can you share builded app please?
i don't wanna install xcode for one app

@khanhicetea

This comment has been minimized.

Show comment
Hide comment
@khanhicetea

khanhicetea Oct 2, 2018

@cron13 I upload here https://github.com/khanhicetea/sequelpro/releases (unsigned app, use as your own risk !)

khanhicetea commented Oct 2, 2018

@cron13 I upload here https://github.com/khanhicetea/sequelpro/releases (unsigned app, use as your own risk !)

@unCleanCode

This comment has been minimized.

Show comment
Hide comment
@unCleanCode

unCleanCode commented Oct 3, 2018

@khanhicetea thanks a lot!

@n9yty

This comment has been minimized.

Show comment
Hide comment
@n9yty

n9yty Oct 4, 2018

Thanks! I had spent some time on this today, managing to get a build easy enough, but it would not connect to my dev box set up in a docker container under Ubuntu. Yet from my host I can use nc to verify the connection, and the last released version of SequelPro connects just fine. I downloaded your build version and it has the same problem. No errors, just a timeout dialog. :(

Actually, see this in the Console:
default 12:38:29.709771 -0500 Sequel Pro LSExceptions shared instance invalidated for timeout.
default 12:38:43.101569 -0500 Sequel Pro 27366555: RECEIVED OUT-OF-SEQUENCE NOTIFICATION: 634 vs 764, 513,

Although I can try several times in a row and they don't seem to appear exactly when I do the connection, but do appear repeatedly.

n9yty commented Oct 4, 2018

Thanks! I had spent some time on this today, managing to get a build easy enough, but it would not connect to my dev box set up in a docker container under Ubuntu. Yet from my host I can use nc to verify the connection, and the last released version of SequelPro connects just fine. I downloaded your build version and it has the same problem. No errors, just a timeout dialog. :(

Actually, see this in the Console:
default 12:38:29.709771 -0500 Sequel Pro LSExceptions shared instance invalidated for timeout.
default 12:38:43.101569 -0500 Sequel Pro 27366555: RECEIVED OUT-OF-SEQUENCE NOTIFICATION: 634 vs 764, 513,

Although I can try several times in a row and they don't seem to appear exactly when I do the connection, but do appear repeatedly.

@khanhicetea

This comment has been minimized.

Show comment
Hide comment
@khanhicetea

khanhicetea Oct 5, 2018

@n9yty I think you should you mysql CLI client to try to connect your container first. Because I use MySQL in docker for Mac to, everything works fine !

khanhicetea commented Oct 5, 2018

@n9yty I think you should you mysql CLI client to try to connect your container first. Because I use MySQL in docker for Mac to, everything works fine !

@n9yty

This comment has been minimized.

Show comment
Hide comment
@n9yty

n9yty Oct 5, 2018

mysql client works, the old version of SequelPro works, the new build(s) do not. Don't know why. Yet I can connect to our web host over ssh, so it is a bit strange. Oh well.

n9yty commented Oct 5, 2018

mysql client works, the old version of SequelPro works, the new build(s) do not. Don't know why. Yet I can connect to our web host over ssh, so it is a bit strange. Oh well.

@stuconnolly

This comment has been minimized.

Show comment
Hide comment
@stuconnolly

stuconnolly Oct 7, 2018

Member

Related to #2758

Member

stuconnolly commented Oct 7, 2018

Related to #2758

@stuconnolly

This comment has been minimized.

Show comment
Hide comment
@stuconnolly

stuconnolly Oct 7, 2018

Member

Fixed in 7d9ba0f

Member

stuconnolly commented Oct 7, 2018

Fixed in 7d9ba0f

@stuconnolly stuconnolly self-assigned this Oct 8, 2018

Kaspik added a commit to Kaspik/sequelpro that referenced this issue Oct 9, 2018

Merge branch 'sp-master'
* sp-master: (27 commits)
  #2485: Fix completion popup background colour when using dark mode.
  Perfom duplicate table name validation on suggested name.
  #2600: Remember copy content when duplicating a table.
  Update copyright year.
  Fix nullability specifier warnings.
  Drop support for i386 architecture to allow building release builds in Xcode 10 (#2785 & #3179)
  Fix UI interaction from background thread when selecting a table that doesn't exist.
  Fix menu item validation warning.
  Tidy up some parameter naming.
  #2485: Fix typo.
  Update copyright year.
  Switch more URL's to https.
  #2485: Remove unncessary dark mode check.
  Disable query column resizing in console.
  Use https links in credits where possible.
  #2636: Fix display of indexes against geometry columns.
  #2636: Fix display of indexes against geometry columns.
  #2485: Make external links in help viewer more readable in dark mode.
  Link to https URLs.
  Another attempt at #3187
  ...

@stuconnolly stuconnolly added this to Done in Sequel Pro 1.2 Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment