New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings #3221

Open
stuconnolly opened this Issue Oct 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@stuconnolly
Member

stuconnolly commented Oct 9, 2018

We currently have about 183 compiler warnings which we should address since they're warnings for a reason.

Note, that some of them will be because we're still targeting the 10.6 SDK.

@Kaspik

This comment has been minimized.

Show comment
Hide comment
@Kaspik

Kaspik Oct 9, 2018

Contributor

PR #3218 - fixing:

  • SPConnectionController.m + SPFilterTableController.m - "Object can not respond to selector" - respondsToSelector is checked so changed type of object
  • SPEditorPreferencePane.m + SPTextView.m + SPCustomQuery.m - return type of method to NSFontPanelModeMask type as it's subclass of method that has this return type
  • SPNavigatorController.m + SPTextView.m - missing default case
  • SPRuleFilterController.m - Compare NSUInteger vs NSInteger - changed type to NSUInteger for all comparasions
Contributor

Kaspik commented Oct 9, 2018

PR #3218 - fixing:

  • SPConnectionController.m + SPFilterTableController.m - "Object can not respond to selector" - respondsToSelector is checked so changed type of object
  • SPEditorPreferencePane.m + SPTextView.m + SPCustomQuery.m - return type of method to NSFontPanelModeMask type as it's subclass of method that has this return type
  • SPNavigatorController.m + SPTextView.m - missing default case
  • SPRuleFilterController.m - Compare NSUInteger vs NSInteger - changed type to NSUInteger for all comparasions

@stuconnolly stuconnolly added the Codebase label Oct 9, 2018

@Kaspik

This comment has been minimized.

Show comment
Hide comment
@Kaspik

Kaspik Oct 9, 2018

Contributor

Except PR #3218 currently postponed until we release 1.2 and then drop 10.6 - 10.x support as a lot of warnings is there because of 10.6 - 10.10 support.

Contributor

Kaspik commented Oct 9, 2018

Except PR #3218 currently postponed until we release 1.2 and then drop 10.6 - 10.x support as a lot of warnings is there because of 10.6 - 10.10 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment