New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter toolbar less useful in build 78067124 than in previous releases #3262

Open
freezey opened this Issue Oct 29, 2018 · 14 comments

Comments

Projects
None yet
@freezey

freezey commented Oct 29, 2018

The experience I am accustomed to with the filter bar in Sequel Pro is that it is always present and that the filter can be quickly cleared by clicking a small X icon.

In the most recent nightly build (7806712 - which I just installed this morning) the filter bar is only present after hitting cmd+F or pulling it up from the menu and I do not see a way to dismiss the filter bar or clear the filter. I tried just erasing the text from the filter input, but it threw an error "No valid SQL expression could be generated. Make sure that you have filled in all required fields".

For me - the previous behavior was much more useful. I browse databases every day and I use the quick filter option dozens of times per day. I prefer having the filter bar open all the time, and having a quick way to dismiss the current filter is a must.

@jpike88

This comment has been minimized.

jpike88 commented Oct 30, 2018

Filter toolbar should be present by default, I had no idea how to get it back until I saw this

@pernielsentikaer

This comment has been minimized.

pernielsentikaer commented Oct 30, 2018

Yes, same problem. Also waiting for something like an inputfield where its possible to write your own search creterias ;)

@dmoagx

This comment has been minimized.

Member

dmoagx commented Oct 30, 2018

I do not see a way to dismiss the filter bar or clear the filter.

I had no idea how to get it back until I saw this

bildschirmfoto 2018-10-30 um 20 47 10 740

@pernielsentikaer

This comment has been minimized.

pernielsentikaer commented Oct 31, 2018

If its possible to "open" it with cmd+f - should'nt it be possible to close it again that way?

@anotherdevs

This comment has been minimized.

anotherdevs commented Oct 31, 2018

Hi

Could it also be possible to not show the 'Filter' button? It takes up a whole new line, and has nothing else to offer. I always press 'Enter' anyways.

@chrisvickers

This comment has been minimized.

chrisvickers commented Oct 31, 2018

I would agree with @pernielsentikaer on this. Either put it back by default or use a shortcut.

@dmoagx

This comment has been minimized.

Member

dmoagx commented Oct 31, 2018

Could it also be possible to not show the 'Filter' button? It takes up a whole new line, and has nothing else to offer. I always press 'Enter' anyways.

No, because the plan is to add other buttons there.

@chumbawumba

This comment has been minimized.

chumbawumba commented Nov 1, 2018

The functionality of the "filter" function, even though visibly similar, doesn't work the same way the old "search" functionality worked. Leaving the field blank, for example, now produces an error. Also, when you switch between filterable fields, the content in the input field is cleared.

@dmoagx

This comment has been minimized.

Member

dmoagx commented Nov 1, 2018

Leaving the field blank, for example, now produces an error.

This will be changed in the future.

@sebastianheise

This comment has been minimized.

sebastianheise commented Nov 5, 2018

I agree that this adds "one extra click/keystroke" - several hundred times throughout my day! :(
Please add at least an option to turn this visible by default.

@ZeldaZach

This comment has been minimized.

ZeldaZach commented Nov 5, 2018

I was about to file a ticket "search bar went missing" before I saw this. Definitely a regression, imo.

An option could be to have a configurable setting, such as "always have search bar visible," to give users the choice. Feels a bit hasty removing it.

Besides that, loving the beta builds. Keep up the great work!

@Jewhurst

This comment has been minimized.

Jewhurst commented Nov 5, 2018

Not sure if this should be its own issue, but this is also quite annoying that it removes the filter typed in everytime you change a dropdown.
screen recording 2018-11-05 at 1 55 15 pm

@zmears

This comment has been minimized.

zmears commented Nov 8, 2018

I also get the "No valid SQL expression could be generated. Make sure that you have filled in all required fields" error when clicking on the arrow to move between tables. It does not filter for the id I have clicked on when going to the related table either.

@iamdanielp

This comment has been minimized.

iamdanielp commented Nov 9, 2018

I also first thought this was some kind of bug before I found this issue. I personally also prefer the previous behaviour with the filter bar always visible. If there's a good reason for changing the behaviour as was indicated by @dmoagx then I also think a setting would make both types of users happy. I also find the "filter button bar" unnecessary but as indicated I guess there's a good reason for this.

Personally I also preferred the older look and feel of the tabs. No they expand the whole window width plus the add tab button is always to the far right. The older behaviour looked better and having the add tab button just next to the last tab was more convenient. But I guess this is a different issue.

Otherwise, great work and I love the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment