New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut CMD-S should default to save query #3318

Open
fulldecent opened this Issue Nov 28, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@fulldecent
Contributor

fulldecent commented Nov 28, 2018

I started downloading other apps because Sequel Pro does not have simple support for saving queries.

Whenever you press CMD-S it saves to some weird format that is NOT an .SQL file.

Much later I found out that the way to save a query is not CMD-S but rather CTRL-CMD-S.


CMD-S should be reserved for the much more common use case of saving a query rather than "saving a connection" whatever that means.

@dmoagx

This comment has been minimized.

Member

dmoagx commented Dec 14, 2018

Every tab in Sequel Pro is a "connection document". This is consistent with e.g. every window in Word or TextEdit being a "text document".

That is actually one of the core concepts in Cocoa: Document based applications.

A document file is supposed to contain all information to restore the application to the state it was in when the document was last saved. That is what Sequel Pro's "connection documents" do and this is also why they are bound to cmd+s.

So Sequel Pro's behavior is in line with how apps are supposed to behave under macOS.

@dmoagx dmoagx added the OpinionPoll label Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment