Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monospaced fonts not used in pop-up editor #3495

Open
gms8994 opened this issue Jul 1, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@gms8994
Copy link

commented Jul 1, 2019

  • Sequel Pro Version: Nightly 5446
  • macOS Version: Mojave 10.14.5
  • MySQL Version: 8.0.16

Description
I've checked the "Use monospaced fonts" box, but the pop-up editor for fields is not using a monospaced font. I've also set the "MySQL content font" to a monospaced font, but it is also not being used.

Steps To Reproduce

  1. Switch Content view to use the popup editor
  2. Double click a field to edit it
  3. Note that it's using a non-monospaced font.

Expected Behaviour
The pop-up editor should display content using a monospaced font when the "Use monospaced fonts" box is checked.

image

@gms8994 gms8994 changed the title Monospaced fonts not used in popup editor Monospaced fonts not used in pop-up editor Jul 1, 2019

@italktocomputers

This comment has been minimized.

Copy link

commented Jul 10, 2019

The problematic code looks to be here:

// If required, use monospaced fonts
#ifndef SP_CODA
if (![prefs objectForKey:SPFieldEditorSheetFont]) {
#endif
[editTextView setFont:
#ifndef SP_CODA
[prefs boolForKey:SPUseMonospacedFonts] ? [NSFont fontWithName:SPDefaultMonospacedFontName size:monospacedFontSize] :
#endif
[NSFont systemFontOfSize:[NSFont smallSystemFontSize]]];
#ifndef SP_CODA
}
else {
[editTextView setFont:[NSUnarchiver unarchiveObjectWithData:[prefs dataForKey:@"FieldEditorSheetFont"]]];
}
#endif

What seems to be happening is the pref [prefs objectForKey:SPFieldEditorSheetFont] (at least for me and I suspect you as well) is equal to the value: AppleSystemUIFont, even if you select 'use monospaced fonts' in preferences. Because [prefs objectForKey:SPFieldEditorSheetFont] evaluates to true, SPDefaultMonospacedFontName is never used as the font.

I'm not really sure what [prefs objectForKey:SPFieldEditorSheetFont] is used for. Maybe a fallback font? I'm thinking this may be a semantic error but would need to investigate some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.