Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Dark mode and colours not compliant #3521

Open
aledexter opened this issue Aug 28, 2019 · 3 comments

Comments

@aledexter
Copy link

commented Aug 28, 2019

MACOS build 5446 Dark mode on

It is not an important ISSUE But i want report that when using the dark mode the colours of the favorites have a contrast too low with the white text and it is not compliant.

I attach an image for example where we use the dark theme and use the color to highlight the favorites. The colour are pastel and very clear so the white of the text it's not readable.

1

We could use tools as
https://contrastchecker.com/
or similar to calculate the perfect contrast but i have not the real HEX code of the favoruties color. I suppose that we can make 2 ways of resolution:

When in dark mode

  1. Leave the text of favorites white but change the colours of the favorites with darker ones (checking their compliance with tools like contrastchecker) .
    or
  2. Leave the colours of the favorites as is but, when one favorites is coloured, CHANGE the colour of the text in black instead of white. That should be the fastest resolution imho.

2

Thank you

@aledexter aledexter changed the title Dark mode and colours not compliant UI: Dark mode and colours not compliant Aug 28, 2019

@aledexter

This comment has been minimized.

Copy link
Author

commented Aug 28, 2019

I see now that there is yet a similar request
#2485

@rockymontana

This comment has been minimized.

Copy link

commented Sep 12, 2019

Love that your issue is about colors not being readable and then use an unreadable color to point out what color to use (red text stating that black is readable). Oh the irony 😘 😂

@aledexter

This comment has been minimized.

Copy link
Author

commented Sep 17, 2019

Love that your issue is about colors not being readable and then use an unreadable color to point out what color to use (red text stating that black is readable). Oh the irony 😘 😂

That's so damn true :) I uploaded a better image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.