Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subclassing MethodsClientImpl easier #77

Merged
merged 1 commit into from Jul 24, 2018
Merged

Make subclassing MethodsClientImpl easier #77

merged 1 commit into from Jul 24, 2018

Conversation

joeltoby
Copy link
Contributor

Changes the access modifiers on MethodsClientImpl's three private doPost methods to protected This makes it much easier to extend. The issue is fully described here #75.

Fixes #75

@joeltoby
Copy link
Contributor Author

@seratch - Sorry for opening and closing my PR. I had a GIT issue which is resolved now

@seratch seratch merged commit e1a3930 into slackapi:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants