bugfix for #4 "creation of test classes fails on nested maven project" #7

Merged
merged 4 commits into from Mar 30, 2017

Conversation

Projects
None yet
2 participants
@fofocx
Contributor

fofocx commented Mar 21, 2017

Use project's path instead of workspace path, can create the test files correctly within maven module project.

@seratch

This comment has been minimized.

Show comment
Hide comment
@seratch

seratch Mar 24, 2017

Owner

@fofocx Thanks for fixing it. You don't need to comment out. After fixing it, I'd love to merge this PR.

Owner

seratch commented Mar 24, 2017

@fofocx Thanks for fixing it. You don't need to comment out. After fixing it, I'd love to merge this PR.

@fofocx

This comment has been minimized.

Show comment
Hide comment
@fofocx

fofocx Mar 27, 2017

Contributor

Hi @seratch, it's my fault. The commented out of code has been removed.

Contributor

fofocx commented Mar 27, 2017

Hi @seratch, it's my fault. The commented out of code has been removed.

- protected String getWorkspaceRootAbsolutePath(IWorkspaceRoot workspaceRoot) {
- return workspaceRoot.getLocation().toString();
- }
+// protected String getWorkspaceRootAbsolutePath(IWorkspaceRoot workspaceRoot) {

This comment has been minimized.

@seratch

seratch Mar 27, 2017

Owner

Could you remove this as well?

@seratch

seratch Mar 27, 2017

Owner

Could you remove this as well?

This comment has been minimized.

@fofocx

fofocx Mar 27, 2017

Contributor

Removed

@fofocx

fofocx Mar 27, 2017

Contributor

Removed

@fofocx

This comment has been minimized.

Show comment
Hide comment
@fofocx

fofocx Mar 27, 2017

Contributor

Urrr.....careless...
Thanks to point that.

Contributor

fofocx commented Mar 27, 2017

Urrr.....careless...
Thanks to point that.

@fofocx

I removed it.

- protected String getWorkspaceRootAbsolutePath(IWorkspaceRoot workspaceRoot) {
- return workspaceRoot.getLocation().toString();
- }
+// protected String getWorkspaceRootAbsolutePath(IWorkspaceRoot workspaceRoot) {

This comment has been minimized.

@fofocx

fofocx Mar 27, 2017

Contributor

Removed

@fofocx

fofocx Mar 27, 2017

Contributor

Removed

@seratch seratch merged commit 8c307eb into seratch:master Mar 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment