Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Incorrectly marking 1.4.0 as incompatible with 1.3 #101

Closed
djc opened this issue Sep 3, 2020 · 13 comments
Closed

Incorrectly marking 1.4.0 as incompatible with 1.3 #101

djc opened this issue Sep 3, 2020 · 13 comments
Assignees

Comments

@djc
Copy link

djc commented Sep 3, 2020

Cargo ignores leading zero components of the version number when considering compatibility. So while 0.1.0 and 0.2.0 are not compatible, 1.3.0 and 1.4.0 are (as are 2.2.0 and 2.5.0). Also as far as I know 0.0.1 and 0.0.2 are also incompatible.

Screen Shot 2020-09-03 at 09 37 48

@serayuzgur
Copy link
Owner

I will prepare a good test case and look for it.

@serayuzgur serayuzgur self-assigned this Sep 4, 2020
@serayuzgur
Copy link
Owner

@djc I couldn't find any doc about it , are you sure ?

https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility

@djc
Copy link
Author

djc commented Jan 5, 2021

What part are you looking for exactly?

"This convention also applies to versions with leading zeros. For example, 0.1.0 and 0.1.2 are compatible, but 0.1.0 and 0.2.0 are not. Similarly, 0.0.1 and 0.0.2 are not compatible."

@djc
Copy link
Author

djc commented Jan 5, 2021

(My biggest pain point currently here is that "1.3" and "1.4" are considered incompatible.)

@serayuzgur
Copy link
Owner

serayuzgur commented Jan 5, 2021

I will work on it, but for a workaround can you use caret '^'? Does it works for you?

@djc
Copy link
Author

djc commented Jan 5, 2021

That basically seems to run into #104.

@serayuzgur
Copy link
Owner

so lets fix #104 at the new version , later we can work on this.

@serayuzgur
Copy link
Owner

This seems ok what do you think ?
Screen Shot 2021-01-05 at 23 53 37

@djc
Copy link
Author

djc commented Jan 5, 2021

Yes, it looks great!

serayuzgur added a commit that referenced this issue Jan 5, 2021
@serayuzgur
Copy link
Owner

please test 0.5.5

@djc
Copy link
Author

djc commented Jan 5, 2021

This is with 0.5.4, still seeing some issues.

Screen Shot 2021-01-05 at 21 59 31

@serayuzgur
Copy link
Owner

I think 0.5.5 will fix these. 0.5.4 was for caret support

@djc
Copy link
Author

djc commented Jan 5, 2021

Yup, 0.5.5 is looking glorious.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants