Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Scripts not in order #7

Closed
skimberk opened this Issue Mar 30, 2012 · 2 comments

Comments

Projects
None yet
2 participants

I'm adding scripts (using addJs()) to my namespace, but in the compacted file, the order isn't maintained. Example:

compact.addNamespace('edit');
compact.ns.edit
    .addJs('ace/ace.js')
    .addJs('ace/mode-html.js')
    .addJs('ace/mode-css.js')
    .addJs('ace/mode-javascript.js')
    .addJs('edit.js');

The scripts are added to the compacted file in this order: mode-html.js -> mode-css.js -> mode-javascripts.js -> edit.js -> ace.js

I was wondering if there is any way to fix this? Thanks.

Owner

serby commented Mar 31, 2012

I think I've found the cause of your problem. I have been calling: async.concat to join the files together. When all the files are small they get concatenated in the correct order. As soon as they are large and vary in size the order is not deterministic.

I've switched to using async.concatSeries which will fix this problem. I'm just making the regression tests and will have a new version of the module published in NPM in the next 30 mins.

Thanks for using compact and taking the time to report the bug.

Owner

serby commented Mar 31, 2012

This is now published to NPM as version 0.0.4

@serby serby closed this Mar 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment