Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Read implementation for &mut Read #684

Merged
merged 1 commit into from Jul 26, 2020
Merged

Conversation

@tinou98
Copy link
Contributor

@tinou98 tinou98 commented Jun 23, 2020

Add Read implementation for &mut Read. Because of the Sealed trait, we can't implement Read in other create.
This kind of trick is required if we want to build a streaming implementation (like asked in #526, #665) in another crate :
We can't use serde_json::Deserializer because we need to give it the Read object the streaming deserializer is working with and there is no way to get it back.

@dtolnay dtolnay force-pushed the tinou98:read-mut branch from d5b8064 to 4003c50 Jul 26, 2020
Copy link
Member

@dtolnay dtolnay left a comment

Thanks!

@dtolnay dtolnay merged commit a1e006a into serde-rs:master Jul 26, 2020
10 checks passed
10 checks passed
Rust nightly
Details
Rust nightly (windows)
Details
Rust beta
Details
Rust stable
Details
Rust 1.32.0
Details
Rust 1.31.0
Details
Rust stable (windows)
Details
Rust 1.36.0
Details
Clippy
Details
Fuzz
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants