Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly enable indexmap/std #885

Merged
merged 1 commit into from May 3, 2022
Merged

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented May 3, 2022

indexmap's use of autocfg doesn't always properly detect std, which is needed if you're using the default S hasher. The "indexmap/std" feature will explicitly force it on.

This does mean that preserve_order requires std, but that was already effectively true by using the default S. Alternatively, we could pick a no_std hasher crate for this, or implement a simple one locally.

dtolnay
dtolnay approved these changes May 3, 2022
Copy link
Member

@dtolnay dtolnay left a comment

Thanks!

@dtolnay dtolnay merged commit f34ef95 into serde-rs:master May 3, 2022
15 checks passed
dtolnay added a commit that referenced this issue May 3, 2022
crapStone added a commit to Calciumdibromid/CaBr2 that referenced this issue May 13, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [serde_json](https://github.com/serde-rs/json) | dependencies | patch | `1.0.79` -> `1.0.81` |

---

### Release Notes

<details>
<summary>serde-rs/json</summary>

### [`v1.0.81`](https://github.com/serde-rs/json/releases/v1.0.81)

[Compare Source](serde-rs/json@v1.0.80...v1.0.81)

-   Work around `indexmap`/`autocfg` not always properly detecting whether a `std` sysroot crate is available ([#&#8203;885](serde-rs/json#885), thanks [@&#8203;cuviper](https://github.com/cuviper))

### [`v1.0.80`](https://github.com/serde-rs/json/releases/v1.0.80)

[Compare Source](serde-rs/json@v1.0.79...v1.0.80)

-   Documentation improvements

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Co-authored-by: crapStone <crapstone01@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1334
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants