Add direct support for i128 and u128 via itoa #940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itoa
natively and unconditionally supportsi128
andu128
, so we can use it instead ofto_string
on those types.This change should have no publicly visible behavior changes. It was previously impossible to customize behavior for 128 bit ints in
Formatter
, so there aren't any public facing behavior changes introduced by the addition of new methods toFormatter
.The MSRV for
serde_json
is 1.36, so there should be no need to conditionally compile anything in this MR. This is affirmed by theitoa
dependency, which unconditionally supports 128 bit integers.