Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume serde_if_integer128 is true #942

Merged
merged 1 commit into from Oct 19, 2022
Merged

Assume serde_if_integer128 is true #942

merged 1 commit into from Oct 19, 2022

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Oct 19, 2022

According to https://github.com/serde-rs/serde/blob/v1.0.145/serde/build.rs#L57-L62, it's false on Emscripten older than 1.40 and other targets older than 1.26. Since serde_json currently requires Rust 1.36 or newer, the only effect is dropping support for using Emscripten with Rust 1.36, 1.37, 1.38, 1.39, which are 3-year-old compilers that nobody has any reason to use when building for Emscripten today, given how premature the support for Emscripten was at the time.

@dtolnay dtolnay merged commit 46c9778 into master Oct 19, 2022
32 checks passed
@dtolnay dtolnay deleted the integer128 branch October 19, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant