Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message duplication between error Display and source() #992

merged 1 commit into from Mar 5, 2023


Copy link

@dtolnay dtolnay commented Mar 5, 2023

Fixes #991.

The same code in the issue now produces:

Error: bad read

Caused by:
    timed out waiting on channel

@dtolnay dtolnay merged commit 3e418b1 into serde-rs:master Mar 5, 2023
@dtolnay dtolnay deleted the errorsource branch March 5, 2023 18:25
crapStone added a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 6, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
| [serde_json]( | dependencies | patch | `1.0.93` -> `1.0.94` |


### Release Notes


### [`v1.0.94`](

[Compare Source](serde-rs/json@v1.0.93...v1.0.94)

-   Fix message duplication between serde_json::Error's `Display` and `source()` ([#&#8203;991](serde-rs/json#991), [#&#8203;992](serde-rs/json#992))



### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.


 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box


This PR has been generated by [Renovate Bot](

Co-authored-by: cabr2-bot <>
Co-authored-by: crapStone <>
Reviewed-by: crapStone <>
Co-authored-by: Calciumdibromid Bot <>
Co-committed-by: Calciumdibromid Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Same message duplicated between source() and Display of serde_json::Error
1 participant