Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only unused_extern_crates instead of the whole rust_2018_idioms lint group in serde_derive-generated code

Merged
merged 1 commit into from May 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2021

I found that this kind of extern only triggers unused_extern_crates warning: https://godbolt.org/z/bMxP8vGE9
Therefore, I think it's unnecessary to #[allow] the whole rust_2018_idioms lint group.

(It's causing some problems for me since I'm also using #[forbid(future_incompatible)], and rust-lang/rust#83213 added some of the lints in rust_2018_idioms to future_incompatible, causing my program fails to compile.)

…oms` lint group in `serde_derive`-generated code
Copy link
Member

@dtolnay dtolnay left a comment

Thanks!

@dtolnay dtolnay merged commit 699bf3a into serde-rs:master May 12, 2021
19 checks passed
@ghost ghost deleted the warning branch May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant