Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated Into conversion involving generic remote derive with getter #2330

merged 2 commits into from Nov 28, 2022


Copy link

@dtolnay dtolnay commented Nov 28, 2022

Fixes #2327.

Currently fails to compile.

    error[E0107]: missing generics for struct `StructGeneric`
       --> test_suite/tests/
    181 | #[serde(remote = "remote::StructGeneric")]
        |                  ^^^^^^^^^^^^^^^^^^^^^^^ expected 1 generic argument
    note: struct defined here, with 1 generic parameter: `T`
       --> test_suite/tests/
    78  |     pub struct StructGeneric<T> {
        |                ^^^^^^^^^^^^^ -
    help: add missing generic argument
    181 | #[serde(remote = StructGeneric<T>)]
        |                  ~~~~~~~~~~~~~~~~
@dtolnay dtolnay merged commit 0daafe4 into serde-rs:master Nov 28, 2022
21 checks passed
@dtolnay dtolnay deleted the remote branch November 28, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Deriving Serialize for a struct from external crate which uses generics
1 participant