Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StdError identical to core::error::Error on feature="unstable" #2344

merged 1 commit into from Dec 16, 2022


Copy link

@dtolnay dtolnay commented Dec 16, 2022

Without this, a user might be forced to implement 2 different duplicate traits when using serde in no-std mode.

impl serde::ser::StdError for MySerError {...}

impl core::error::Error for MySerError {...}

impl serde::Serializer for MySerializer {
    type Error = MySerError;

@dtolnay dtolnay merged commit f261184 into serde-rs:master Dec 16, 2022
21 checks passed
@dtolnay dtolnay deleted the coreerror branch December 16, 2022 18:22
@dtolnay dtolnay mentioned this pull request Dec 16, 2022
6 tasks
crapStone added a commit to Calciumdibromid/CaBr2 that referenced this pull request Dec 22, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
| [serde]( ([source]( | dependencies | patch | `1.0.149` -> `1.0.151` |


### Release Notes


### [`v1.0.151`](

[Compare Source](serde-rs/serde@v1.0.150...v1.0.151)

-   Update `serde::`{`ser`,`de`}`::StdError` to re-export `core::error::Error` when serde is built with `feature="std"` **off** and `feature="unstable"` **on** ([#&#8203;2344](serde-rs/serde#2344))

### [`v1.0.150`](

[Compare Source](serde-rs/serde@v1.0.149...v1.0.150)

-   Relax some trait bounds from the `Serialize` impl of `HashMap` and `BTreeMap` ([#&#8203;2334](serde-rs/serde#2334))
-   Enable `Serialize` and `Deserialize` impls of `std::sync::atomic` types on more platforms ([#&#8203;2337](serde-rs/serde#2337), thanks [@&#8203;badboy](



### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.


 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box


This PR has been generated by [Renovate Bot](

Co-authored-by: cabr2-bot <>
Co-authored-by: crapStone <>
Reviewed-by: crapStone <>
Co-authored-by: Calciumdibromid Bot <>
Co-committed-by: Calciumdibromid Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant