This repository has been archived by the owner on May 6, 2020. It is now read-only.
Reimplement derive to work with cfg_attr #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems pretty reasonable to me. As a side note, we ought to actually start implementing tests for these edge cases. I know we get coverage for it by way of the serde tests, but we probably should probably have some tests for things like this here. I'm not quite sure what those tests would look like without needing to implement some complicated macros to drive the testing. |
homu
added a commit
that referenced
this pull request
Jun 16, 2016
Reimplement derive to work with cfg_attr Fixes serde-rs/serde#148. The implementation expands `cfg_attr` and `derive` in-line during decorator expansion rather than as pre/post-expansion passes. I think this is a simpler and more correct design, but at the expense of being more invasive into the libsyntax code.
homu
added a commit
to serde-rs/serde
that referenced
this pull request
Jun 23, 2016
Add test for expansion inside of cfg_attr Test for #148. Requires serde-deprecated/syntex#71 + Syntex release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes serde-rs/serde#148.
The implementation expands
cfg_attrandderivein-line during decorator expansion rather than as pre/post-expansion passes. I think this is a simpler and more correct design, but at the expense of being more invasive into the libsyntax code.