From 8978ef5211582ee33adbc145fb4bf06ee4c6f185 Mon Sep 17 00:00:00 2001 From: Jan Molak <1089173+jan-molak@users.noreply.github.com> Date: Thu, 4 Jan 2024 16:16:40 +0100 Subject: [PATCH] Updated tests to correctly assert on displayName or name --- .../WhenGeneratingRequirementsReportData.groovy | 6 +++--- ...ingRequirementDefinitionDescriptionFromADirectory.groovy | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/serenity-core/src/test/groovy/net/thucydides/core/requirements/WhenGeneratingRequirementsReportData.groovy b/serenity-core/src/test/groovy/net/thucydides/core/requirements/WhenGeneratingRequirementsReportData.groovy index fda81d449..47d073c15 100644 --- a/serenity-core/src/test/groovy/net/thucydides/core/requirements/WhenGeneratingRequirementsReportData.groovy +++ b/serenity-core/src/test/groovy/net/thucydides/core/requirements/WhenGeneratingRequirementsReportData.groovy @@ -27,7 +27,7 @@ class WhenGeneratingRequirementsReportData extends Specification { List requirementsProviders ReportNameProvider reportNameProvider - + def setup() { FeatureCache.getCache().close() def vars = new MockEnvironmentVariables() @@ -49,10 +49,10 @@ class WhenGeneratingRequirementsReportData extends Specification { RequirementsOutcomes outcomes = requirmentsOutcomeFactory.buildRequirementsOutcomesFrom(noTestOutcomes) then: "all the known capabilities should be listed" def requirementsNames = outcomes.requirementOutcomes.collect {it.requirement.name} - requirementsNames == ["Grow cucumbers", "Grow potatoes", "Grow wheat", "Raise chickens", "Apples", "Nice zucchinis", "Potatoes"] + requirementsNames == ["grow cucumbers", "Grow potatoes", "Grow wheat", "raise_chickens", "Apples", "Nice zucchinis", "Potatoes"] and: "the display name should be obtained from the narrative file where present" def requirementsDisplayNames = outcomes.requirementOutcomes.collect {it.requirement.displayName} - requirementsDisplayNames == ["Grow cucumbers", "Grow lots of potatoes", "Grow wheat", "Raise chickens", "Apples", "Nice zucchinis", "Potatoes title"] + requirementsDisplayNames == ["Grow cucumbers", "Grow potatoes", "Grow wheat", "Raise chickens", "Apples", "Nice zucchinis", "Potatoes title"] } def "should report no test results for requirements without associated tests"() { diff --git a/serenity-core/src/test/groovy/net/thucydides/core/requirements/WhenLoadingRequirementDefinitionDescriptionFromADirectory.groovy b/serenity-core/src/test/groovy/net/thucydides/core/requirements/WhenLoadingRequirementDefinitionDescriptionFromADirectory.groovy index ed614610c..157903825 100644 --- a/serenity-core/src/test/groovy/net/thucydides/core/requirements/WhenLoadingRequirementDefinitionDescriptionFromADirectory.groovy +++ b/serenity-core/src/test/groovy/net/thucydides/core/requirements/WhenLoadingRequirementDefinitionDescriptionFromADirectory.groovy @@ -70,7 +70,7 @@ class WhenLoadingRequirementDefinitionDescriptionFromADirectory extends Specific then: "the narrativeText should be found" narrative.present and: "the narrativeText title and description should be loaded" - narrative.get().title.get() == "Grow more apples" + narrative.get().title.get() == "Grow apples" narrative.get().text.contains("In order to make apple pies") && narrative.get().text.contains("As a farmer") && narrative.get().text.contains("I want to grow apples")