fix(cucumber): ensure async events are correctly synchronised before …

…the test run finishes SerenityBDDReporter emits reports after the test run completes #405
serenity-js · Jan 23, 2020 · d69aeae · d69aeae
1 parent d39bc7c
commit d69aeae
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/packages/cucumber/src/listeners/cucumber-0.ts b/packages/cucumber/src/listeners/cucumber-0.ts
@@ -87,8 +87,10 @@ export = function ({ serenity, notifier, loader, cache }: Dependencies) {
             notifier.scenarioFinished(map.get(Scenario).onLine(line), map.getFirst(Feature), scenarioOutcomeFrom(result));
         });
 
-        this.registerHandler('AfterFeatures', features => {
-            notifier.testRunFinished();
+        this.registerHandler('AfterFeatures', (features, callback) => {
+            serenity.waitForNextCue()
+                .then(() => notifier.testRunFinished())
+                .then(() => callback(), error => callback(error));
         });
     };
 };

diff --git a/packages/cucumber/src/listeners/cucumber-3.ts b/packages/cucumber/src/listeners/cucumber-3.ts
@@ -11,7 +11,10 @@ export = function (dependencies: Dependencies) {
         });
 
         AfterAll(function () {
-            dependencies.notifier.testRunFinished();
+            return dependencies.serenity.waitForNextCue()
+                .then(() => {
+                    dependencies.notifier.testRunFinished();
+                });
         });
     });
 

diff --git a/packages/cucumber/src/listeners/cucumber-4.ts b/packages/cucumber/src/listeners/cucumber-4.ts
@@ -11,7 +11,10 @@ export = function (dependencies: Dependencies) {
     });
 
     AfterAll(function () {
-        dependencies.notifier.testRunFinished();
+        return dependencies.serenity.waitForNextCue()
+            .then(() => {
+                dependencies.notifier.testRunFinished();
+            });
     });
 
     return cucumberEventProtocolAdapter(dependencies);