Skip to content
Permalink
Browse files
fix(protractor): updated the version of Chromedriver
Made the tests compatible with Chrome's new security requirements
  • Loading branch information
jan-molak committed Dec 11, 2019
1 parent 758170e commit f1c6a5746c2d54ab595cfa8a5e1531388a9eaeda
@@ -46,7 +46,7 @@
"@serenity-js/serenity-bdd": "2.0.1-alpha.90",
"@types/cucumber": "^4.0.7",
"@types/express": "^4.16.1",
"chromedriver": "^77.0.0",
"chromedriver": "^79.0.0",
"cucumber": "6.0.2",
"express": "^4.16.4",
"npm-failsafe": "0.4.1",
@@ -44,7 +44,7 @@
"@serenity-js/rest": "2.0.1-alpha.90",
"@serenity-js/serenity-bdd": "2.0.1-alpha.90",
"@types/jasmine": "^3.4.0",
"chromedriver": "^77.0.0",
"chromedriver": "^79.0.0",
"npm-failsafe": "0.4.1",
"protractor": "^5.4.2",
"ts-node": "^8.4.1",
@@ -46,7 +46,7 @@
"@serenity-js/serenity-bdd": "2.0.1-alpha.90",
"@types/express": "^4.16.1",
"@types/jasmine": "^3.4.0",
"chromedriver": "^77.0.0",
"chromedriver": "^79.0.0",
"express": "^4.16.4",
"jasmine": "^3.4.0",
"npm-failsafe": "0.4.1",
@@ -34,7 +34,7 @@
"@serenity-js/core": "2.0.1-alpha.90",
"@serenity-js/jasmine": "2.0.1-alpha.90",
"@serenity-js/protractor": "2.0.1-alpha.92",
"chromedriver": "^77.0.0",
"chromedriver": "^79.0.0",
"protractor": "^5.4.2"
},
"devDependencies": {
@@ -70,7 +70,7 @@
"@types/html-minifier": "^3.5.2",
"@types/mocha": "^5.2.6",
"@types/selenium-webdriver": "^3.0.14",
"chromedriver": "^77.0.0",
"chromedriver": "^79.0.0",
"express": "^4.16.4",
"html-minifier": "^3.5.21",
"protractor": "^5.4.2",
@@ -22,6 +22,7 @@ exports.config = {

capabilities: {
browserName: 'chrome',
acceptInsecureCerts : true,

loggingPrefs: {
browser: 'INFO',
@@ -19,6 +19,8 @@ describe('Cookie', () => {
httpOnly: !! req.query.httpOnly,
secure: !! req.query.secure,
expires: req.query.expires && new Date(req.query.expires),
// https://www.chromestatus.com/feature/5633521622188032
// sameSite: !! req.query.secure ? 'None' : undefined,
}).status(200).send();
});

@@ -195,7 +197,7 @@ describe('Cookie', () => {

/** @test {Cookie} */
/** @test {Cookie#isSecure} */
it('returns an undefined when it can\'t retrieve it', () => Sid.attemptsTo(
it(`returns an undefined when it can't retrieve it`, () => Sid.attemptsTo(
Navigate.to(cookieCutterURLFor('/cookie?name=favourite&value=chocolate-chip')),
Ensure.that(Cookie.isSecure('not-so-favourite'), equals(undefined)),
));

0 comments on commit f1c6a57

Please sign in to comment.