fix(console-reporter): don't pollute the log with stack traces of Imp…

…lementationPendingError
serenity-js · Jan 8, 2021 · fb3b97a · fb3b97a
1 parent 121f391
commit fb3b97a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/console-reporter/spec/stage/crew/console-reporter/ConsoleReporter.spec.ts b/packages/console-reporter/spec/stage/crew/console-reporter/ConsoleReporter.spec.ts
@@ -155,9 +155,6 @@ describe('ConsoleReporter', () => {
                 | ☕Implementation pending (28ms)
                 |
                 |   ImplementationPendingError: Step not implemented
-                |       at CucumberEventProtocolAdapter.outcomeFrom (/Users/jan/Projects/serenity-js/packages/cucumber/src/listeners/CucumberEventProtocolAdapter.ts:179:54)
-                |       at EventEmitter.<anonymous> (/Users/jan/Projects/serenity-js/packages/cucumber/src/listeners/CucumberEventProtocolAdapter.ts:155:28)
-                |       at EventEmitter.emit (events.js:203:15)
                 | ================================================================================
                 | Execution Summary
                 |

diff --git a/packages/console-reporter/src/stage/crew/console-reporter/ConsoleReporter.ts b/packages/console-reporter/src/stage/crew/console-reporter/ConsoleReporter.ts
@@ -310,9 +310,14 @@ export class ConsoleReporter implements StageCrewMember {
                 if (e.outcome instanceof ProblemIndication) {
 
                     this.printer.println();
+
                     this.printer.indent();
 
-                    this.printer.println(e.outcome.error.stack);
+                    if (e.outcome instanceof ImplementationPending) {
+                        this.printer.println(`${ e.outcome.error.name }: ${ e.outcome.error.message }`);
+                    } else {
+                        this.printer.println(e.outcome.error.stack);
+                    }
 
                     this.printer.outdent();
                 }