Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using Examples, if Feature description is the same, then only last test is shown in generated report #220

Closed
emosGambler opened this issue May 23, 2018 · 2 comments
Closed

When using Examples, if Feature description is the same, then only last test is shown in generated report #220

emosGambler opened this issue May 23, 2018 · 2 comments
Labels
enhancement @serenity-js/cucumber

Comments

@emosGambler
Copy link

@emosGambler emosGambler commented May 23, 2018 •
edited

Hi, I think I've found some issue.

Steps to reproduce:

  1. Create a feature with Examples table. Feature description should not be parametrized:
    https://i.imgur.com/wrQs9kn.png

  2. Implement steps and run these tests. Tests are executed in loop and the console confirms it:
    https://i.imgur.com/ss8Myzo.png

  3. Generated report does only show last test loop:
    https://i.imgur.com/zBl2KpR.png
    https://i.imgur.com/Oqw5s1I.png

Additional comment:
When I have parametrized Feature description using provided variable product (Feature: Add product to the todo list), then report shows correct number of tests executed. Can you please review if this is a valid issue?

Repository with this issue:
https://github.com/emosGambler/protractor-typescript-cucumber-serenity-example/tree/feature/its-a-bug
@jan-molak jan-molak mentioned this issue May 28, 2018
Closed
5 tasks
@jan-molak
Copy link
Member

@jan-molak jan-molak commented May 28, 2018

Hi there and thanks for taking the time to prepare such a detailed report, much appreciated!
You're right, this is an issue with the current implementation of the cucumber js integration.

It has been reported in #168, where I also mention a way to work around the problem while the root cause is being addressed (#162).

Stay tuned!
Jan

@emosGambler
Copy link
Author

@emosGambler emosGambler commented Jun 3, 2018

Hi Jan,

Yup, I have figured out the same workaround. Thank you for the reply and I am looking forward to see this fixed.

Best regards,
Jacek

@jan-molak jan-molak added the enhancement label Jun 26, 2018
@jan-molak jan-molak added the @serenity-js/cucumber label Jul 26, 2018
jan-molak added a commit that referenced this issue Jul 26, 2018
@jan-molak
feat(cucumber): @serenity-js/cucumber adapter re-write
de8a565 
affects: @serenity-js/core, @serenity-js/cucumber, @integration/cucumber, @integration/testing-tools

The new version will make it possible to support scenario outlines (#168, #220) and provide
additional context in the report
jan-molak added a commit that referenced this issue Jul 29, 2018
@jan-molak
feat(cucumber): @serenity-js/cucumber adapter re-write
e19c358 
affects: @serenity-js/core, @serenity-js/cucumber, @integration/cucumber, @integration/testing-tools

The new version will make it possible to support scenario outlines (#168, #220) and provide
additional context in the report
nbarrett pushed a commit to nbarrett/serenity-js that referenced this issue May 1, 2020
@dependabot-preview
Merge pull request serenity-js#220 from serenity-js/dependabot/npm_an…
d63221a 
…d_yarn/serenity-js/rest-2.3.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement @serenity-js/cucumber
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jan-molak @emosGambler