Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cucumber 2 (rc's) #28

Closed
nicojs opened this issue Feb 20, 2017 · 15 comments
Closed

Support for cucumber 2 (rc's) #28

nicojs opened this issue Feb 20, 2017 · 15 comments
Labels
enhancement @serenity-js/cucumber

Comments

@nicojs
Copy link

@nicojs nicojs commented Feb 20, 2017

I believe support for cucumber 2 is missing at the moment. Is that correct?

$ npm ls serenity-js
+-- UNMET PEER DEPENDENCY cucumber@2.0.0-rc.7
`-- serenity-js@1.2.0

Installed both cucumber@2.0.0-rc7 and serenity-js 1.2.0.

node ..\..\node_modules\protractor\bin\protractor 
(node:11616) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
[08:00:18] I/launcher - Running 1 instances of WebDriver
[08:00:18] I/direct - Using ChromeDriver directly...
[08:00:22] E/launcher - Error: TypeError: Cannot call a class as a function
Error: TypeError: Cannot call a class as a function

I believe that error has to do with the cli changes in cucumber. See this PR for protractor-cucumber-framework

@jan-molak
Copy link
Member

@jan-molak jan-molak commented Feb 20, 2017

Hey @nicojs and thanks for giving Serenity/JS a try!

You're right, the project currently supports the latest stable version of Cucumber.js, which at the time of writing is 1.3.x.

To properly support Cucumber 1.3 and 2.x in a single code base I'll need to move Serenity/JS onto something like Lerna and Lerna Semantic Release, which I was planning to do before Cucumber 2.x becomes stable. Once Serenity/JS becomes a multi-module project, different test framework adapters could depend on different versions of the same package.

@jan-molak jan-molak added the @serenity-js/cucumber label Feb 20, 2017
@nicojs
Copy link
Author

@nicojs nicojs commented Feb 21, 2017

Ok, thanks for the update.

@jan-molak
Copy link
Member

@jan-molak jan-molak commented Feb 21, 2017

Speaking of which, it would be great to know how many people are already using Cucumber 2.x?
If you'd like me to prioritise this functionality, please 👍 the OP's ticket.

@jan-molak jan-molak added serenity-cucumber2 enhancement labels Feb 21, 2017
jan-molak added a commit that referenced this issue Mar 23, 2017
affects: serenity-js.cucumber-2, serenity-js.testing

Initial support for Cucumber 2. To properly support Protractor, the main serenity-js module will
need to be changed to support loading external test framework adapters. In the meantime, it should
be possible to use this module without Protractor. #28
@wswebcreation
Copy link
Contributor

@wswebcreation wswebcreation commented Jun 4, 2017

Using Cucumber 2 now in a project without Serenity, but if you need some help with it let me know.

@artem-v-shamsutdinov
Copy link

@artem-v-shamsutdinov artem-v-shamsutdinov commented Nov 27, 2017

Hello,

We are writing an Angular 5 project and are currently using vanilla Cucumber 3.1. What is the status on the support for Cucumber 2+?

Thanks, :)

@vasiokos
Copy link

@vasiokos vasiokos commented Feb 5, 2018

Is there any news regarding serenity and latest cucumber versions?
Thanks,

@jan-molak
Copy link
Member

@jan-molak jan-molak commented Feb 6, 2018

Yes, it's a WIP, I'm planning to work on that right after #162, which seems more pressing.

@artem-v-shamsutdinov
Copy link

@artem-v-shamsutdinov artem-v-shamsutdinov commented Apr 6, 2018

Hello,

Any news on support for Cucumber 2+?

Thanks, :)

@matt-blanchette
Copy link

@matt-blanchette matt-blanchette commented Jun 22, 2018

This would be nice to have support of Cucumber expressions for step definitions

@jan-molak
Copy link
Member

@jan-molak jan-molak commented Jun 28, 2018

My work on #162 ended up with me re-writing most of the internals of @serenity-js/core... I should be able to publish that within the next couple of weeks and then this ticket should be fairly easy to tackle as well. Stay tuned!

jan-molak added a commit that referenced this issue Aug 28, 2018
…and 2.3

affects: @integration/cucumber-1-runner, @integration/cucumber-2-runner, @integration/cucumber

Executing the same set of end-to-end integration tests against both Cucumber 1.3 and 2.3 ensures
good test coverage and limits test code duplication

ISSUES CLOSED: #28
jan-molak added a commit that referenced this issue Aug 29, 2018
affects: @serenity-js/core, @serenity-js/cucumber, @integration/cucumber-1-runner,
@integration/cucumber-2-runner, @integration/cucumber-3-runner, @integration/cucumber,
@integration/testing-tools

ISSUES CLOSED: #28
jan-molak added a commit that referenced this issue Aug 29, 2018
affects: @serenity-js/cucumber, @integration/cucumber-1-runner, @integration/cucumber-2-runner,
@integration/cucumber-3-runner, @integration/cucumber-4-runner, @integration/cucumber

ISSUES CLOSED: #28
jan-molak added a commit that referenced this issue Sep 27, 2018
affects: @serenity-js/cucumber, @integration/cucumber-1-runner, @integration/cucumber-2-runner,
@integration/cucumber-3-runner, @integration/cucumber-4-runner, @integration/cucumber-5-runner,
@integration/cucumber, @integration/testing-tools,
@serenity-js-examples/cucumber-domain-level-testing, @serenity-js-examples/cucumber-reporting

ISSUES CLOSED: Closes #28
@wywrotowiec
Copy link

@wywrotowiec wywrotowiec commented Apr 12, 2019

Hello,
I see that support for Cucumber 2+ was added on 2.0 branch. Is it stable enough for start using it ?Any news about official release ?
Thanks, :)

@jan-molak
Copy link
Member

@jan-molak jan-molak commented Apr 12, 2019

Hi @wywrotowiec! Serenity/JS alpha is available on npm right now.
You can reference it in your package.json as @serenity-js/core: "next".

Now, here's the small print: I haven't written the developer guide for it yet, nor any nice configuration abstractions (that's my plan for the next few weeks), so while the main modules are stable and the APIs will most likely change very little if at all, the way you configure the framework will change.

If you'd like to use the alpha version now you'd need to rely on the examples and a gitter chat I'm setting up as well. Give me a shout if you're feeling adventurous and want to try the alpha, or if you'd rather wait for the official release (which I'm hoping to finish within the next few weeks).

@wywrotowiec
Copy link

@wywrotowiec wywrotowiec commented Apr 19, 2019

Hi Jan!
Thank you for your matter-of-fact response and sharing info about upcoming release that everyone is excited about . We are just starting our adventure in js tests and for sure we will go with new version. If it is mater of few weeks we will wait for official release to give better first impression for developers and more chance of successful introduction.

@iranicus
Copy link

@iranicus iranicus commented Jan 2, 2020

Currently sorting out a protractor-cucumber setup now for one of our angular 4 (to be updated to angular 8 this year) projects, to which I'll be using cucumber 5. The plan being for me to switch over to serenity 2 and pitch the framework likely mid 2020, taking a look at the commits recently to the serenity 2 alpha version I spotted the support for cucumber 5 referencing this ticket so looking forward to coming back to this later in the year to try it out :>. Thanks much.

@jan-molak
Copy link
Member

@jan-molak jan-molak commented Mar 9, 2020

Hi all! Serenity/JS 2.0 is live and ships with a brand new Cucumber adapter that supports any version of Cucumber.js, all the way from 1.x to 6.x

Check out the template project and examples and let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement @serenity-js/cucumber
Projects
None yet
Development

No branches or pull requests

8 participants