Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with build on windows. (see #137) #142

Closed
wants to merge 1 commit into from

Conversation

lufecir
Copy link

@lufecir lufecir commented Jan 12, 2018

Hi Jan,

Here is the pull request containing the fixes I did for building on Windows as discussed in #137.

With the update you did to replace nock with axios-mock-adapter, there is only a single test left failing on the 'rest' package:

  1. Interactions delete resource "before each" hook for "should perform as the actor.":
    Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

Still all the protractor tests in 'serenity-js' package are failing.

I have added the full log of my latest build (from this branch) in attachment.

Regards,

Luc
serenity-build.log

@jan-molak
Copy link
Member

@jan-molak jan-molak commented Feb 4, 2020

Thanks for your contribution, @lufecir! Version 2 of Serenity/JS should build on Windows, but please let me know should you find any issues.

@jan-molak jan-molak closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants