#159 feat: add ConditionalPerformable to permit flow control #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarrett
changed the title
nbarrett
pushed a commit
to nbarrett/serenity-js
that referenced
this pull request
Feb 4, 2018
nbarrett
pushed a commit
to nbarrett/serenity-js
that referenced
this pull request
Feb 4, 2018
|
Thanks for integrating this feature into the base product @jan-molak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Here's the specs and code to permit the following kinds of conditional flow control:
Check.whether(boolean).andIfSo(...).otherwise(...)Check.whetherQuestionTrue(Question<boolean>).andIfSo(...).otherwise(...)Check.whetherPromiseTrue(Question<PromiseLike<boolean>>).andIfSo(...).otherwise(...)Actually - I wanted the api to be
Check.whether()for all constructor arguments for consistency with the java api, but couldn't find a way to overload the different types. Can you suggest a tweak for this please @jan-molak ?