Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too little padding on longer scenario names #375

Closed
wants to merge 1 commit into from

Conversation

KyleFairns
Copy link
Contributor

@KyleFairns KyleFairns commented Nov 29, 2019

Noticed an issue where longer scenario names were 1 space short of being in line with the longer names in the summary, surrounding the ternary if with brackets and padding both to the same length fixes this issue

Before:
Screenshot 2019-11-29 at 15 38 05

After:
Screenshot 2019-11-29 at 16 46 45

Noticed an issue where longer scenario names were 1 space short of being in line with the longer names in the summary, surrounding the ternary if with brackets and padding both to the same length fixes this issue
@jan-molak
Copy link
Member

@jan-molak jan-molak commented Nov 29, 2019

Cool, thanks! Could you please update the tests to make them pass?

To run them locally you can run the following command from the project root

make clean verify

Or:

cd packages/console-reporter
npm test

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants