Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide ability to disable napt trigger generation #7

Merged
merged 1 commit into from
Aug 14, 2022
Merged

provide ability to disable napt trigger generation #7

merged 1 commit into from
Aug 14, 2022

Conversation

sergei-lapin
Copy link
Owner

resolves #6

@sergei-lapin sergei-lapin mentioned this pull request Aug 12, 2022
Closed
ZacSweers
ZacSweers reviewed Aug 12, 2022
View reviewed changes
Copy link
Contributor

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, I would add something to the task update checks to mark itself as up-to-date if napt trigger generation is disabled, so the task never runs. Otherwise I think build caching won't work for this task since there would be no output

@ZacSweers ZacSweers mentioned this pull request Aug 12, 2022
Merged
@sergei-lapin sergei-lapin force-pushed the optionally-disable-napt-trigger-generation branch 2 times, most recently from 7d52922 to 3416835 Compare August 13, 2022 08:29
@sergei-lapin sergei-lapin force-pushed the optionally-disable-napt-trigger-generation branch from 3416835 to a33955a Compare August 13, 2022 08:46
@sergei-lapin sergei-lapin force-pushed the optionally-disable-napt-trigger-generation branch from a33955a to 56d904a Compare August 13, 2022 09:10
@sergei-lapin sergei-lapin merged commit a17e878 into main Aug 14, 2022
@sergei-lapin sergei-lapin deleted the optionally-disable-napt-trigger-generation branch August 14, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacSweers ZacSweers ZacSweers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: option to disable NaptTrigger file generation
2 participants
@sergei-lapin @ZacSweers