New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added references to Sitecore pipelines necessary for testing updates to layout fields with Sitecore 9 #191

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
2 participants
@AndyButland

AndyButland commented Nov 11, 2017

Am currently working on a project just upgraded to Sitecore 9, and found a few FakeDB related tests failing. The common issue was tests being made on layout fields.

From some decompiling I could see that the Sitecore.Data.Fields.LayoutField.GetFieldValue() method had changed, to require a couple of methods referenced from pipeline components that it wasn't using in version 8.2. Adding these two to the configuration as per this PR, recompiling and then referenced the built Sitecore.FakeDb.dll resolved this.

@sergeyshushlyapin

This comment has been minimized.

Show comment
Hide comment
@sergeyshushlyapin

sergeyshushlyapin Nov 23, 2017

Owner

Hi @AndyButland,

Sorry for the late reply. I spent some time researched Sitecore 9 integration. To make it fully compatible with Sitecore 9 more (breaking) changes are needed. I started working on that here. Likely, that will be FakeDb 2 (and it'll take some time ;).

From the other side, your fix brings no harm to the existing 8.x versions so I think that's fine to include it into FakerDb 1.x.

Thanks for your contribution!

Owner

sergeyshushlyapin commented Nov 23, 2017

Hi @AndyButland,

Sorry for the late reply. I spent some time researched Sitecore 9 integration. To make it fully compatible with Sitecore 9 more (breaking) changes are needed. I started working on that here. Likely, that will be FakeDb 2 (and it'll take some time ;).

From the other side, your fix brings no harm to the existing 8.x versions so I think that's fine to include it into FakerDb 1.x.

Thanks for your contribution!

@sergeyshushlyapin sergeyshushlyapin merged commit d59e678 into sergeyshushlyapin:master Nov 23, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sergeyshushlyapin

This comment has been minimized.

Show comment
Hide comment
@sergeyshushlyapin
Owner

sergeyshushlyapin commented Nov 23, 2017

Released as v1.7.1.

@sergeyshushlyapin sergeyshushlyapin referenced this pull request Dec 12, 2017

Merged

Feature/v9 #358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment