Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in v-add-letsencrypt-user #1253

Closed
jaredearle opened this issue Aug 4, 2017 · 13 comments

Comments

Projects
None yet
9 participants
@jaredearle
Copy link

commented Aug 4, 2017

Operating System (OS/VERSION):

All

VestaCP Version:

0.9.8

Issue:

Typo discovered - https://github.com/serghey-rodin/vesta/blob/master/bin/v-add-letsencrypt-user#L58

"perm" should be "pem"

@bikerdave

This comment has been minimized.

Copy link

commented Aug 4, 2017

+1

@noogen

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2017

Confirm a bug in 0.9.8 v17 on Ubuntu 16.04.03 LTS

@4t4r1

This comment has been minimized.

Copy link

commented Aug 8, 2017

+1

@narookak

This comment has been minimized.

Copy link

commented Aug 16, 2017

confirmed issue with "Ubuntu 14.04.5 LTS" too.
root@webapps01:~# v-add-letsencrypt-domain user domain.com
pkey: Invalid format "perm" for -inform
pkey: Use -help for summary.
Error: LetsEncrypt account registration 400

tried correcting the typo, but getting below error after that.

sed: can't read /usr/local/vesta/data/queue/letsencrypt.pipe: No such file or directory

@noogen

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2017

manually create the file by doing: touch /usr/local/vesta/data/queue/letsencrypt.pipe
VestaCP has issue creating this file, sometime.

@anton-reutov anton-reutov added the bug label Sep 13, 2017

@anton-reutov

This comment has been minimized.

Copy link
Collaborator

commented Sep 14, 2017

@narookak
DO
Ubuntu 14.04 x64
v-add-letsencrypt-domain user domain.com

I cant reproduce this problem. The certificate is added successfully

@narookak

This comment has been minimized.

Copy link

commented Sep 15, 2017

@anton-reutov, thanks, I will give it a try again.

@anton-reutov

This comment has been minimized.

Copy link
Collaborator

commented Sep 15, 2017

@narookak, try and let me know if problem still exits

@narookak

This comment has been minimized.

Copy link

commented Sep 15, 2017

This is working now, after applying fix suggested by @noogen

@szbnwer

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2017

i think that missing pipe is because the installer, i think i didn't see it in the debian installer when the stucked development and forking topics came up

@sviriden

This comment has been minimized.

Copy link

commented Sep 18, 2017

How to reproduce on DO:

If I install Vesta on totally clean server — everything works fine.

But if I add PHP7.1 repo and update&upgrade system before install, I get this error:
Error: LetsEncrypt account registration 400

  1. Create Droplet Ubuntu 16.04.3 x32
  2. ssh root@IP
add-apt-repository ppa:ondrej/php
apt-get update
apt-get upgrade -y
apt-get dist-upgrade
curl -O http://vestacp.com/pub/vst-install.sh
sudo groupdel admin 
bash vst-install.sh
  1. Change DNS A record for used domain
  2. Open Vesta CP and try to receive LE certificate => error
  3. After fixing file /usr/local/vesta/bin/v-add-letsencrypt-user =>everything works
@noogen

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2017

Do we really need to re-create? This is reported as a typo: https://github.com/serghey-rodin/vesta/blob/master/bin/v-add-letsencrypt-user#L58

exponent=$(openssl pkey -inform perm -in "$key" -noout -text_pub |\

It is specified here, valid values are: DER or PEM

https://wiki.openssl.org/index.php/Manual:Pkey(1)

-inform DER|PEM
This specifies the input format DER or PEM.

In this case, the typo is perm with the extra r instead of pem

hellodanielting added a commit to hellodanielting/vesta that referenced this issue Oct 4, 2017

@dpeca

This comment has been minimized.

Copy link
Collaborator

commented Oct 22, 2017

Fix accepted.

@dpeca dpeca closed this Oct 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.