New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #1731 #1734

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
3 participants
@skullwritter
Contributor

skullwritter commented Oct 25, 2018

Now checks if the domain is suspended (WEB or EMAIL or DNS) if so, continue to the next domain

Fix: #1731
Now checks if the domain is suspended (WEB or EMAIL or DNS) if so, continue to the next domain
@moucho

This comment has been minimized.

moucho commented Oct 26, 2018

Correct me if I'm wrong, but I guess if EMAIL or DNS are suspended it should attempt to renew the certificate nonetheless, because the web could be working (external DNS for example)
IMO

@skullwritter

This comment has been minimized.

Contributor

skullwritter commented Oct 26, 2018

@moucho if dns is suspended, you cannot query the server for the name.
but i can modify if everyone wants to, i don't care, i've only put the checks to insure that the domain was fully active

@moucho

This comment has been minimized.

moucho commented Oct 30, 2018

Thinking on some examples:

  • If I use Cloudflare for my domain example.com , with DNS added but suspended on VestaCP just for the sake of it, it should renew SSL certificate.
  • I may not want to use Mail support on example.com, just a website with SSL but I didn't remove support, only suspended it. Or maybe I'm going to use Zoho or GSuite, but I suspended Mail support so I can keep the mail accounts I had before migrating to one of those mail services.

IMO it should only check if the domain is active, doesn't need to check for DNS or Mail support, suspended non existant.

@skullwritter

This comment has been minimized.

Contributor

skullwritter commented Oct 30, 2018

@moucho i'll change

@dpeca dpeca merged commit 2996b8a into serghey-rodin:master Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment