Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error 400 details updating LE challenge #1937

Open
wants to merge 2 commits into
base: master
from

Conversation

@shakaran
Copy link

shakaran commented Sep 11, 2019

In a string like:

{ "type": "urn:ietf:params:acme:error:malformed", "detail": "Unable to update challenge :: authorization must be pending", "status": 400 }

It picks the value for "details". So the user will have more info about the let's encrypt error and not only a 400 blind error, for example:

Instead of only:
Error: Let's Encrypt validation status 400

Now is improved to:

Error: Let's Encrypt validation status 400. Details: Unable to update challenge :: authorization must be pending

In a string like: { "type": "urn:ietf:params:acme:error:malformed", "detail": "Unable to update challenge :: authorization must be pending", "status": 400 }

It picks the value for "details". So the user will have more info about the let's encrypt error and not only a 400 blind error
@carlosfriascf

This comment has been minimized.

Copy link

carlosfriascf commented Sep 17, 2019

Added to carlosfriascf@5818079
Good job!

Copy link

evs38 left a comment

This patch needs to be updated due to ae328a0 changes

@shakaran

This comment has been minimized.

Copy link
Author

shakaran commented Sep 25, 2019

@evs38 updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.