Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-66054 Configuration icon should add the needed parameters #3204

Closed
wants to merge 566 commits into from
Closed

LPS-66054 Configuration icon should add the needed parameters #3204

wants to merge 566 commits into from

Conversation

robertoDiaz
Copy link

@robertoDiaz robertoDiaz commented Jun 9, 2016 •
edited by sergiogonzalez

No description provided.

brianchandotcom and others added 30 commits June 7, 2016 20:00
@brianchandotcom
artifact:ignore users-admin-web 2.0.5 prep next
0d9fc5e
@brianchandotcom
Sync
0b6bbc6
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/announcements/.gitr…
3cc153e 
…epo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/blogs/.gitrepo'.
62706a8
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/bookmarks/.gitrepo'.
81e3aa2
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/comment/.gitrepo'.
87c1f60
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/directory/.gitrepo'.
b693fc5
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/document-library/.g…
db06fc0 
…itrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/invitation/.gitrepo'.
7507c01
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/item-selector/.gitr…
9840fde 
…epo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/message-boards/.git…
f5d2332 
…repo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/microblogs/.gitrepo'.
f83733d
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/notifications/.gitr…
8769d73 
…epo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/social/.gitrepo'.
0c05735
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/wiki/.gitrepo'.
75a0c29
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/calendar/.gitr…
ca07b69 
…epo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/dynamic-data-l…
12692ad 
…ists/.gitrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/dynamic-data-m…
e7ece8f 
…apping/.gitrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/polls/.gitrepo'.
248d6c3
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/portal-workflo…
9c6db66 
…w/.gitrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/configuration-admin/.g…
bc82b33 
…itrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/contacts/.gitrepo'.
e48e5e9
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/expando/.gitrepo'.
2e4eb65
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/frontend-js/.gitrepo'.
d558dd7
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/frontend-theme/.gitrepo'.
257b0b2
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/login/.gitrepo'.
5f3184c
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/map/.gitrepo'.
3e7726d
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/mobile-device-rules/.g…
797d012 
…itrepo'.
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/monitoring/.gitrepo'.
a3cfac8
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/password-policies-admi…
205f2bd 
…n/.gitrepo'.
brianchandotcom and others added 25 commits June 8, 2016 16:25
@brianchandotcom
artifact:ignore portal-template-freemarker 2.0.5 prep next
fcfa449
@brianchandotcom
Sync
4288ee6
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/portal-template/.gitre…
a225359 
…po'.
@shuyangzhou @brianchandotcom
LPS-65693 Remove war wrapper bundle to war bundle tracking.
f97e470
@shuyangzhou @brianchandotcom
LPS-65693 Use the wrapper bundle's info to reverse calcualte the war …
00a9507 
…bundle info for uninstall
@brianchandotcom
portal-lpkg-deployer 1.0.8 packageinfo
07fbcd5
@brianchandotcom
artifact:ignore portal-lpkg-deployer 1.0.8 prep next
b22c644
@brianchandotcom
portal-lpkg-deployer 1.0.8 apply
46726af
@brianchandotcom
artifact:ignore marketplace-deployer 2.0.5 prep next
87ba8fa
@brianchandotcom
artifact:ignore marketplace-service 2.1.4 prep next
f4708f0
@brianchandotcom
Sync
a78f776
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/marketplace/.gitrepo'.
7cdc5a7
@robertoDiaz
LPS-66463 Lexiconify move article view
582ac3c
@robertoDiaz
LPS-66054 Remove unnecessary jsp to simplify
887a550
@robertoDiaz
LPS-66054 Create the popup with the same style as used in documents a…
58df50a 
…nd media select folder popup
@robertoDiaz
LPS-66054 Add the container to the jsp
58001be
@robertoDiaz
LPS-66054 Update logic to make it consistent with select folder logic…
0ee3d2b 
… from DL
@robertoDiaz
LPS-66054 SF - Remove the fieldset
e66487d
@robertoDiaz
LPS-66054 Default root folder name is home
cb0a76c
@robertoDiaz
LPS-66054 Behaviour should be like DL
fabfcd6
@robertoDiaz
LPS-66054 Unused
c5d442b
@robertoDiaz
LPS-66054 Use only one search container
f6f318d
@robertoDiaz
LPS-66054 Get the articles using the parent resource prim key instead…
2ca55a5 
… folder id
@robertoDiaz
LPS-66054 Lang properties
1e0022e
@robertoDiaz
LPS-66054 Configuration icon should add the needed parameters
a41fb03
@robertoDiaz
Copy link
Author

@sergiogonzalez

He encontrado algunas incosistencias en como se gestionan los breadcrumb entries de KB (basicamente que a nivel de api estan muy limitados) ademas de un posible error de comprobaciones, por la que el servicio permite crear bucles entre padres e hijos.

Para limitar el scope de esta pull no he entrado a solucionar ninguno de estos errores.

Si quieres podemos arreglarlos mañana

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 1 hour 17 minutes 8 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 7cdc5a74f4bad9cb851bc6cfe179cf6f11abb592

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    64 Jobs Passed.
    22 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/compile-jsp-jdk7
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #8978
           [exec] :apps:knowledge-base:knowledge-base-web:jar UP-TO-DATE
     [exec] :apps:knowledge-base:knowledge-base-web:unzipJar
     [exec] :apps:knowledge-base:knowledge-base-web:generateJSPJava
     [exec] /opt/dev/projects/github/liferay-portal/modules/apps/knowledge-base/knowledge-base-web/build/jspc/org/apache/jsp/admin/common/select_005fparent_jsp.java:487: error: no suitable method found for addPortletBreadcrumbEntries(long,long,long,String,HttpServletRequest,RenderResponse)
     [exec]       KnowledgeBaseUtil.addPortletBreadcrumbEntries(originalParentResourcePrimKey, parentResourceClassNameId, parentResourcePrimKey, templatePath + "select_parent.jsp", request, renderResponse);
     [exec]                        ^
     [exec]     method KnowledgeBaseUtil.addPortletBreadcrumbEntries(Map,HttpServletRequest,RenderResponse) is not applicable
     [exec]       (actual and formal argument lists differ in length)
     [exec]     method KnowledgeBaseUtil.addPortletBreadcrumbEntries(long,long,String,HttpServletRequest,RenderResponse) is not applicable
     [exec]       (actual and formal argument lists differ in length)
     [exec]     method KnowledgeBaseUtil.addPortletBreadcrumbEntries(long,long,long,long,String,HttpServletRequest,RenderResponse) is not applicable
     [exec]       (actual and formal argument lists differ in length)
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 1 error
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:knowledge-base:knowledge-base-web:compileJSP'.
     [exec] > Compilation failed; see the compiler error output for details.
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:knowledge-base:knowledge-base-web:compileJSP'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mariadb100-jdk8/0
    Job Results:

    1 Test Passed.
    1 Test Failed.

    1. PoshiRunner.test[623Upgrade#View623DataArchive] - 623Upgrade#View623DataArchive - Poshi Summary - Console Output
  4. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mariadb100-jdk8/1
    Job Results:

    1 Test Passed.
    1 Test Failed.

    1. PoshiRunner.test[612Upgrade#View612DataArchive] - 612Upgrade#View612DataArchive - Poshi Summary - Console Output
  5. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk8/10
    Job Results:

    31 Tests Passed.
    1 Test Failed.

    1. PoshiRunner.test[RecyclebinUsecase#RestoreDMDocumentFromFolderCP] - RecyclebinUsecase#RestoreDMDocumentFromFolderCP - RecyclebinWebcontent#RestoreWebcontent - SearchUsecase#SearchTwiceHideSitesFacet - Poshi Summary - Console Output
  6. ...
For upstream results, click here.

@sergiogonzalez
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@sergiogonzalez
Copy link
Owner

Pull request submitted to brianchandotcom#40655. See changes here.

:octocat: Sent from GH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone