What is the propose of .link &:before and &:after css classes ? #232

Closed
ravpacheco opened this Issue May 8, 2017 · 7 comments

Comments

2 participants
@ravpacheco
Contributor

ravpacheco commented May 8, 2017

Hello Sergio,

what was your propose with .link &:before and &:after css classes (on social-links.sass)?
This classes make a little bug on mobile version. I don't know why but with this classes each social icon use a aditional space and the responsive page get a unecessary horizontal scroll.

image

You can check this issue in my site (ravpacheco.com) using mobile version.

To fix this I removed this classes and everything worked fine. You really need this classes or can I send a pull request removing this things ?

Note: This problem occur only with you enable a more than 6 social icon

@sergiokopplin

This comment has been minimized.

Show comment
Hide comment
@sergiokopplin

sergiokopplin May 13, 2017

Owner

If i remember, it's used for this 'popup'.

image

Owner

sergiokopplin commented May 13, 2017

If i remember, it's used for this 'popup'.

image

@sergiokopplin

This comment has been minimized.

Show comment
Hide comment
@sergiokopplin

sergiokopplin May 13, 2017

Owner

Have you edited the code on this? Seems to be not working in your application.

Owner

sergiokopplin commented May 13, 2017

Have you edited the code on this? Seems to be not working in your application.

@ravpacheco

This comment has been minimized.

Show comment
Hide comment
@ravpacheco

ravpacheco May 13, 2017

Contributor

Yes @sergiokopplin , I removed this on my application and now the popup don't work. I will try to fix this without remove the popup and send to you the results. Tks :)

Contributor

ravpacheco commented May 13, 2017

Yes @sergiokopplin , I removed this on my application and now the popup don't work. I will try to fix this without remove the popup and send to you the results. Tks :)

@sergiokopplin

This comment has been minimized.

Show comment
Hide comment
@sergiokopplin

sergiokopplin May 13, 2017

Owner

OK, sounds good!
Nice work with the translated content!

Owner

sergiokopplin commented May 13, 2017

OK, sounds good!
Nice work with the translated content!

@ravpacheco

This comment has been minimized.

Show comment
Hide comment
@ravpacheco

ravpacheco May 13, 2017

Contributor

Thank you. I'm trying to improve the translation process to proppose a pull request. As soon as I finish, I'll let you know.

Contributor

ravpacheco commented May 13, 2017

Thank you. I'm trying to improve the translation process to proppose a pull request. As soon as I finish, I'll let you know.

@sergiokopplin

This comment has been minimized.

Show comment
Hide comment
@sergiokopplin

sergiokopplin May 13, 2017

Owner

Valeu mesmo!! Era exatamente isso que eu ia pedir!

Owner

sergiokopplin commented May 13, 2017

Valeu mesmo!! Era exatamente isso que eu ia pedir!

ravpacheco added a commit to ravpacheco/ravpacheco.github.io that referenced this issue May 20, 2017

@ravpacheco

This comment has been minimized.

Show comment
Hide comment
@ravpacheco

ravpacheco May 20, 2017

Contributor

@sergiokopplin I did a pull request in order to fix this issue.

#234

Contributor

ravpacheco commented May 20, 2017

@sergiokopplin I did a pull request in order to fix this issue.

#234

sergiokopplin added a commit that referenced this issue May 21, 2017

Merge pull request #234 from ravpacheco/gh-pages
Fix social link issue (#232) on mobile versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment