Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakudo first-index deprecation fix #102

Closed
wants to merge 5 commits into from
Closed

Rakudo first-index deprecation fix #102

wants to merge 5 commits into from

Conversation

azawawi
Copy link
Contributor

@azawawi azawawi commented Oct 21, 2015

Please let me know if you need any changes to it.

@azawawi azawawi changed the title Performance compile time enhancement + deprecation fix Rakudo first-index deprecation fix Oct 21, 2015
@azawawi
Copy link
Contributor Author

azawawi commented Oct 21, 2015

I have updated the PR to include just the deprecation fix given that future rakudo module pre-compilation will fix the issue detailed in the reverted commits.

Thanks for your time,
Ahmad

@jonathanstowe
Copy link
Collaborator

Hi,
unfortunately there is a merge conflict on this, I could fix it manually but it would lose some of the history, could you pull the latest upstream, fix the conflicts and re-push? Don't think it should be too much to fix.

Thanks.

@azawawi
Copy link
Contributor Author

azawawi commented Oct 21, 2015

This has already been fixed in 407fa82 and this PR #98.

I will close this PR. Thanks for your time 👍

@azawawi azawawi closed this Oct 21, 2015
@jonathanstowe
Copy link
Collaborator

Hi,
I think we would still be interested in the load time enhancement parts though if you could do another PR at some point :)

@azawawi
Copy link
Contributor Author

azawawi commented Oct 21, 2015

Sure. When pre-compilation lands in rakudo, I will go through it again. Meanwhile, I will go back to work on my pet project (i.e. Selenium::WebDriver). Help Wanted 👍

@jonathanstowe
Copy link
Collaborator

Maybe we want to get some "Help Wanted" page for module authors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants