New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-allocate a buffer when getting content #187
Conversation
|
maxrss is reduced to |
|
Turns out I've mixed up two different changes and I need to get them sorted out before this can be merged. |
Instead of growing it with `~=`. This reduces the amount of memory used considerably.
|
@sergot @ugexe @jonathanstowe any idea what's up with the failing test? It's saying |
|
Seems to be ok now? |
|
Restarted the build and it passed. 👍 |
|
Merge it then? :) |
|
OK, I hate to say it, but can we revert this please? :) This is currently making Pastebin::Gist uninstallable because it hangs with 100% CPU on its tests. I've noticed this issue indirectly in whateverable also. Note that HTTP::UserAgent tests are not affected by this regression (with and without NETWORK_TESTING), which means that this should be resolved with tests. Until then a revert will do. |
|
See this PR instead of reverting: #188 |
Instead of growing it with
~=. This reduced the amount of memory usedconsiderably.