Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove node6 support and upgrade codebase #1851

Merged
merged 1 commit into from May 2, 2019

Conversation

1 participant
@reconbot
Copy link
Member

commented Apr 30, 2019

  • use async functions
  • use Object.entries/Object.values
  • use Object spreading
  • also remove node9 from the test suite, it's not LTS

BREAKING: bindings now use async functions so they’ll never throw, only reject

@reconbot reconbot requested a review from HipsterBrown Apr 30, 2019

@serialport serialport deleted a comment from codecov bot Apr 30, 2019

@serialport serialport deleted a comment from codecov bot Apr 30, 2019

chore: remove node6 support and upgrade codebase
- use async functions
- use Object.entries/Object.values
- use Object spreading

BREAKING: bindings now use async functions so they’ll never throw, only reject

@reconbot reconbot force-pushed the reconbot/remove-node6 branch from d0e16ec to 629bc09 Apr 30, 2019

@reconbot reconbot merged commit d4f15c0 into master May 2, 2019

6 checks passed

codecov/project 65.89% (+1.05%) compared to f7587ed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/clever-fermat-89ff0d/deploy-preview Deploy preview ready!
Details

@reconbot reconbot deleted the reconbot/remove-node6 branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.