Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output template processing improvements #958

Closed
nblumhardt opened this Issue Apr 6, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@nblumhardt
Copy link
Member

nblumhardt commented Apr 6, 2017

#944 adds new functionality to output templates, in the form of {Properties} support.

Serilog.Sinks.Literate, the primary external consumer of OutputProperties.GetOutputProperties(), can't make use of the new functionality directly - in order to pretty-print the property object it needs to reimplement a lot of the logic there.

This leaves us at a good point to make some changes:

  • Break the literate console sink's dependency on OutputProperties.GetOutputProperties() entirely, copying some implementation across if we have to
  • Make the newly-added GetOutputProperties() overload internal
  • Mark the old GetOutputProperties() method obsolete
  • Rewrite MessageTemplateTextFormatter to avoid all of the unnecessary allocations that it currently makes via GetOutputProperties(); we can consider #956 in the process
@nblumhardt

This comment has been minimized.

Copy link
Member Author

nblumhardt commented Jun 27, 2017

This shipped in 2.5.

@nblumhardt nblumhardt closed this Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.