New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less surprising "child logger" level configuration #654

Merged
merged 1 commit into from Feb 9, 2016

Conversation

Projects
None yet
2 participants
@nblumhardt
Copy link
Member

nblumhardt commented Feb 1, 2016

Found a few rough edges in WriteTo.Logger() - fixes:

  • When using WriteTo.Logger(lc => ...) the sub-logger inherits the level configured on the parent
  • Last-in always wins when setting minimum levels even when switching between LoggingLevelSwitch and basic level config
  • WriteTo.Logger no longer ignores the passed-in level switch argument if present (consistent with other sinks)
Less surprising "child logger" level configuration
 - When using `WriteTo.Logger(lc => ...)` the sub-logger inherits the level configured on the parent
 - Last-in always wins when setting minimum levels even when switching between `LoggingLevelSwitch` and basic level config
 - `WriteTo.Logger` no longer ignores the passed-in level switch argument if present (consistent with other sinks)
@merbla

This comment has been minimized.

Copy link
Contributor

merbla commented Feb 1, 2016

LTGM. Keen to get these sort of semantics into the v2 doco.

@nblumhardt

This comment has been minimized.

Copy link
Member Author

nblumhardt commented Feb 3, 2016

Yeah, it will be tedious but I'm hoping we can get a pretty exhaustive changelist up when 2.0 ships.

This PR should be ready to go... :)

@nblumhardt

This comment has been minimized.

Copy link
Member Author

nblumhardt commented Feb 9, 2016

@merbla considering your LGTM a :shipit:... 💥

nblumhardt added a commit that referenced this pull request Feb 9, 2016

Merge pull request #654 from nblumhardt/fix-child-logger-level
Less surprising "child logger" level configuration

@nblumhardt nblumhardt merged commit fb9ae29 into serilog:dev Feb 9, 2016

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@merbla

This comment has been minimized.

Copy link
Contributor

merbla commented Feb 9, 2016

Sorry @nblumhardt my button clicking leaves a lot to be desired...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment