-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup integration tests for the Web API #104
Labels
web-api
This issue is related to the Coffer Web API
Comments
This was referenced May 11, 2022
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we don't have Web API integration tests in our pipeline. We should create them and add them to the pipeline. Solution: created `server-integration` test suite with two unit tests.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we don't have Web API integration tests in our pipeline. We should create them and add them to the pipeline. Solution: created `server-integration` test suite with two unit tests.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we have some integration tests for Web API, but don't have makefile target to run them. Solution: created two scripts: 1. Spins up two vault instances and writes their pids in file. 2. Reads pids from file, deletes it and kills vault instances. Also added `server-integration` makefile target to run server integration tests.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we have some server integration tests but we don't run them in pipeline. Solution: add `server integration` task in pipeline.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we don't have Web API integration tests in our pipeline. We should create them and add them to the pipeline. Solution: created `server-integration` test suite with two unit tests.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we have some integration tests for Web API, but don't have makefile target to run them. Solution: created two scripts: 1. Spins up two vault instances and writes their pids in file. 2. Reads pids from file, deletes it and kills vault instances. Also added `server-integration` makefile target to run server integration tests.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we have some server integration tests but we don't run them in pipeline. Solution: add `server integration` task in pipeline.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we have some integration tests for Web API, but don't have makefile target to run them. Solution: created two scripts: 1. Spins up two vault instances and writes their pids in file. 2. Reads pids from file, deletes it and kills vault instances. Also added `server-integration` makefile target to run server integration tests.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we have some server integration tests but we don't run them in pipeline. Solution: add `server integration` task in pipeline.
DK318
added a commit
that referenced
this issue
May 16, 2022
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we don't have Web API integration tests in our pipeline. We should create them and add them to the pipeline. Solution: created `server-integration` test suite with two unit tests.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we have some integration tests for Web API, but don't have makefile target to run them. Solution: created two scripts: 1. Spins up two vault instances and writes their pids in file. 2. Reads pids from file, deletes it and kills vault instances. Also added `server-integration` makefile target to run server integration tests.
DK318
added a commit
that referenced
this issue
May 16, 2022
Problem: we have some server integration tests but we don't run them in pipeline. Solution: add `server integration` task in pipeline.
DK318
added a commit
that referenced
this issue
May 17, 2022
DK318
added a commit
that referenced
this issue
May 17, 2022
DK318
added a commit
that referenced
this issue
May 17, 2022
DK318
added a commit
that referenced
this issue
May 17, 2022
Problem: we don't have Web API integration tests in our pipeline. We should create them and add them to the pipeline. Solution: created `server-integration` test suite with two unit tests.
DK318
added a commit
that referenced
this issue
May 17, 2022
Problem: we have some integration tests for Web API, but don't have makefile target to run them. Solution: added `server-integration` makefile target to run server integration tests.
DK318
added a commit
that referenced
this issue
May 17, 2022
Problem: we have some server integration tests but we don't run them in pipeline. Solution: add `server integration` task in pipeline.
DK318
added a commit
that referenced
this issue
May 19, 2022
DK318
added a commit
that referenced
this issue
May 19, 2022
DK318
added a commit
that referenced
this issue
May 21, 2022
DK318
added a commit
that referenced
this issue
May 21, 2022
DK318
added a commit
that referenced
this issue
May 24, 2022
DK318
added a commit
that referenced
this issue
May 24, 2022
DK318
added a commit
that referenced
this issue
May 24, 2022
DK318
added a commit
that referenced
this issue
May 24, 2022
Problem: we don't have Web API integration tests in our pipeline. We should create them and add them to the pipeline. Solution: created `server-integration` test suite with two unit tests.
DK318
added a commit
that referenced
this issue
May 24, 2022
Problem: we have some integration tests for Web API, but don't have makefile target to run them. Solution: added `server-integration` makefile target to run server integration tests.
DK318
added a commit
that referenced
this issue
May 24, 2022
Problem: we have some server integration tests but we don't run them in pipeline. Solution: add `server integration` task in pipeline.
DK318
added a commit
that referenced
this issue
May 24, 2022
…tests-pipeline [#104] Web API integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clarification and motivation
We have a few tests for the Web API written in mocha.
The main reason why they were written in javascript in the first place was so that they would serve as documentation for whoever writes the frontend. However:
I think we could still achieve our goal (documenting the web API) if we re-write the tests in Haskell, without using a servant client and without relying on coffer's data types/encoders/decoders. We could just write json literals in the tests (e.g. with
aesonQQ
), manually add the headers, etc.These tests should:
coffer:test:server-integration
Main
before running the tests (just likescripts/run-bats-tests.sh
).bats
), we delete all entries in between tests.NumThreads
option to 1 (and usinglocalOption
inMain
).Let's:
We'll write the remaining tests in a separate issue
Acceptance criteria
The text was updated successfully, but these errors were encountered: