/ batphone Public
Making it work on devices without sdcards #32
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
I tried to use a device without sdcard, and the application crashes.
The first commit (c5923b3) essentially allows to store serval-mesh.db in internal storage if there is no sdcard.
But after that, rhizome still tries to use /sdcard storage. We could modify its path in serval.conf, but we can also disable rhizome. Such an option was partially implemented (adding "rhizome.enable=0" in serval.conf), but 2 things were missing:
The second commit (efc94c5) fixes a part of 2).
Two commits in serval-dna (ad3b316 and c31c1fe) fix 1) and the rest of 2).
After these changes, I successfully phoned another device (without root access, with a wifi router) on a Motorola Milestone Android 2.2, having no sdcard (disabling rhizome).