Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upob_dup() did not preserve source position #66
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
rom1v
Jul 5, 2013
Contributor
Arf, it breaks tests/routing…
I think there is a problem: shouldn't ob_dup() preserve position on the destination buffer?
|
Arf, it breaks I think there is a problem: shouldn't |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lakeman
Jul 5, 2013
Member
Yeah, that set of functions don't quite behave like you might expect them
to, and the rest of the application depends on that behaviour.
I'd actually like to implement a reference counted replacement that would
allow us to use scatter gather I/O for relaying packets directly from the
buffer we received them in without any memory copying.
On Fri, Jul 5, 2013 at 7:41 PM, ®om notifications@github.com wrote:
Arf, it breaks tests/routing…
I think there is a problem: shouldn't ob_dup() preserve position on the
destination buffer?—
Reply to this email directly or view it on GitHubhttps://github.com/servalproject/serval-dna/pull/66#issuecomment-20510566
.
|
Yeah, that set of functions don't quite behave like you might expect them I'd actually like to implement a reference counted replacement that would On Fri, Jul 5, 2013 at 7:41 PM, ®om notifications@github.com wrote:
|
rom1v commentedJul 5, 2013
ob_append_bytes() changes the position, so it must be reset.